From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, agraf@suse.de, david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH 2/2] spapr: populate ibm,loc-code
Date: Fri, 27 Mar 2015 11:51:58 +0530 [thread overview]
Message-ID: <877fu3m03d.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <5514CB9C.4000701@ozlabs.ru>
Alexey Kardashevskiy <aik@ozlabs.ru> writes:
>> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
>> index 95d666e..dd97258 100644
>> --- a/hw/vfio/pci.c
>> +++ b/hw/vfio/pci.c
>> @@ -3319,6 +3319,24 @@ static void vfio_unregister_req_notifier(VFIOPCIDevice *vdev)
>> vdev->req_enabled = false;
>> }
>>
>> +bool vfio_get_devspec(PCIDevice *pdev, char **value)
>
>
> This function can live in hw/ppc/spapr_pci_vfio.c. Something like
> object_property_get_str(OBJECT(pdev), "host", NULL) will return the host
> address, and this is all you really want from VFIO here.
Looking more deeper, "host" is part of VFIOPCIDevice, which is not
available in hw/pci/spapr_pci_vfio.c
This was the reason, I had to move this code to hw/vfio/pci.c
Is there a way to get that?
Regards
Nikunj
next prev parent reply other threads:[~2015-03-27 6:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 6:42 [Qemu-devel] [PATCH 1/2] vfio-pci: add flag to identify vfio pci device Nikunj A Dadhania
2015-03-26 6:42 ` [Qemu-devel] [PATCH 2/2] spapr: populate ibm,loc-code Nikunj A Dadhania
2015-03-27 3:16 ` Alexey Kardashevskiy
2015-03-27 4:29 ` Nikunj A Dadhania
2015-03-27 6:21 ` Nikunj A Dadhania [this message]
2015-03-27 6:38 ` Alexey Kardashevskiy
2015-03-27 3:28 ` David Gibson
2015-03-27 3:58 ` Alexey Kardashevskiy
2015-03-27 4:34 ` Nikunj A Dadhania
2015-03-27 4:57 ` David Gibson
2015-03-27 6:24 ` Nikunj A Dadhania
2015-03-27 3:05 ` [Qemu-devel] [PATCH 1/2] vfio-pci: add flag to identify vfio pci device Alexey Kardashevskiy
2015-03-31 18:17 ` Alex Williamson
2015-04-01 5:05 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fu3m03d.fsf@linux.vnet.ibm.com \
--to=nikunj@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).