From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8tvu-0004JW-NU for qemu-devel@nongnu.org; Mon, 12 Aug 2013 11:21:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8tvl-0003fj-P7 for qemu-devel@nongnu.org; Mon, 12 Aug 2013 11:21:22 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:54854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8tvl-0003fY-In for qemu-devel@nongnu.org; Mon, 12 Aug 2013 11:21:13 -0400 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Aug 2013 09:21:12 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 3868F19D804C for ; Mon, 12 Aug 2013 09:20:57 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7CFL38i150812 for ; Mon, 12 Aug 2013 09:21:04 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r7CFL3et031659 for ; Mon, 12 Aug 2013 09:21:03 -0600 From: Anthony Liguori In-Reply-To: <20130812145436.GA31779@redhat.com> References: <1376316104-11269-1-git-send-email-aliguori@us.ibm.com> <20130812145436.GA31779@redhat.com> Date: Mon, 12 Aug 2013 10:20:41 -0500 Message-ID: <877gfr9bqu.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v2] pc: drop external DSDT loading List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Gerd Hoffmann "Michael S. Tsirkin" writes: > On Mon, Aug 12, 2013 at 09:01:44AM -0500, Anthony Liguori wrote: >> This breaks migration and is unneeded with modern SeaBIOS. >> >> Signed-off-by: Anthony Liguori > > Hmm don't we want to keep it around for machine types > 1.4.0 and 1.5.0? Hrm, why? Regards, Anthony Liguori > > By the way, copy stable as well? > Loading it unconditonally is a cross > version migration bug that we probably want to fix > on stable branch - disabling for 1.3.0 and older. > >> --- >> v1 -> v2 >> - Still load external DSDT for q35 >> --- >> hw/i386/pc_piix.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >> index 95c45b8..311574a 100644 >> --- a/hw/i386/pc_piix.c >> +++ b/hw/i386/pc_piix.c >> @@ -103,7 +103,6 @@ static void pc_init1(MemoryRegion *system_memory, >> OBJECT(icc_bridge), NULL); >> >> pc_cpus_init(cpu_model, icc_bridge); >> - pc_acpi_init("acpi-dsdt.aml"); >> >> if (kvm_enabled() && kvmclock_enabled) { >> kvmclock_create(); >> -- >> 1.8.0