From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38814)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UkDDC-0004Zn-Jt
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:53:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UkDDA-0007ts-NZ
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:53:10 -0400
Received: from mail-ob0-x229.google.com ([2607:f8b0:4003:c01::229]:45248)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UkDDA-0007tg-Jo
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:53:08 -0400
Received: by mail-ob0-f169.google.com with SMTP id up14so2530232obb.0
	for <qemu-devel@nongnu.org>; Wed, 05 Jun 2013 05:53:08 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <20130605111044.GL31830@redhat.com>
References: <1370371954-8479-1-git-send-email-pbonzini@redhat.com>
	<51AF09FC.50308@suse.de> <20130605111044.GL31830@redhat.com>
Date: Wed, 05 Jun 2013 07:53:05 -0500
Message-ID: <877gi867ny.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions
	to instance_finalize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

"Michael S. Tsirkin" <mst@redhat.com> writes:

> On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas F=C3=A4rber wrote:
>> Am 04.06.2013 20:51, schrieb Paolo Bonzini:
>> > This series changes all PCI devices (the sole to support hotplug
>> > _and_ use MemoryRegions) to do memory_region_del_subregion at
>> > unrealize time, and memory_region_destroy at instance_finalize
>> > time.
>>=20
>> The general idea looks good.
>>=20
>> Could you please follow-up with a patch that switches from exit to
>> unrealize?
>
> What do you guys think about changing the name to something
> else e.g. "free" or "destroy"?

exit/unrealize !=3D free/destroy.

You don't actually free anything.  See 00/39 in this series for a
precise description.

> unrealize is not a word in english:
> http://dictionary.cambridge.org/spellcheck/american-english/?q=3Dunrealize

English is a fluid language.  I wouldn't worry too much about that.

Regards,

Anthony Liguori

> I can do it easily if people agree.
>
>> use BUS(), PCI_DEVICE() etc. to hide this.
>>=20
>> Andreas
>>=20
>> --=20
>> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
>> GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=
=BCrnberg