From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49647)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ULP1V-0007eQ-55
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 22:26:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ULP1U-0007Jz-90
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 22:26:33 -0400
Received: from mail-ve0-f174.google.com ([209.85.128.174]:49913)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ULP1U-0007Jo-4r
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 22:26:32 -0400
Received: by mail-ve0-f174.google.com with SMTP id jz10so175465veb.19
	for <qemu-devel@nongnu.org>; Thu, 28 Mar 2013 19:26:31 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <20130328114112.GF3077@dhcp-200-207.str.redhat.com>
References: <1362491612-19226-1-git-send-email-aliguori@us.ibm.com>
	<1362491612-19226-2-git-send-email-aliguori@us.ibm.com>
	<20130313112659.GE2309@dhcp-200-207.str.redhat.com>
	<87mwu7s8ga.fsf@codemonkey.ws>
	<20130328114112.GF3077@dhcp-200-207.str.redhat.com>
Date: Thu, 28 Mar 2013 21:26:28 -0500
Message-ID: <877gkr0wmj.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [RFC PATCH 1/8] qtest: add libqos
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Kevin Wolf <kwolf@redhat.com> writes:

> Am 13.03.2013 um 15:03 hat Anthony Liguori geschrieben:
>> You are correct, it should look something like:
>> 
>> if (addr & PCI_BASE_ADDRESS_SPACE_IO) {
>>     size = (1ULL << ctzl(addr & PCI_BASE_ADDRESS_IO_MASK));
>> } else {
>>     size = (1ULL << ctzl(addr & PCI_BASE_ADDRESS_MEM_MASK));
>> }
>> 
>> This doesn't deal with 64-bit bars though.
>> 
>> I'll update in the next round.  I think this has worked for me because I
>> have only done single device testing.  I did switch from ffz when I
>> rebased but I think ffz would still have this problem.
>
> For when are you planning the next round?

I'll send one out soon.  Perhaps tomorrow if all goes well.

Regards,

Anthony Liguori

> Will we get this in time to make use of it in 1.5?

>
> Kevin