Re: [Qemu-devel] [PATCH] i2c: factor out VMSD to parent class

[Juan Quintela <quintela@redhat.com>]

Peter Crosthwaite <peter.crosthwaite@petalogix.com> wrote:
> On Tue, Aug 14, 2012 at 6:46 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 14 August 2012 09:27, Juan Quintela <quintela@redhat.com> wrote:
>>> "Peter A. G. Crosthwaite" <peter.crosthwaite@petalogix.com> wrote:
>>>> Hi All. PMM raised a query on a recent series of mine (the SSI series) about
>>>> handling VMSD for devices which define state at multiple levels of the QOM
>>>> heirachy.
>>
>>> - If you ask me, I would very much preffer something like PCI devices,
>>>   where the 1st field of any specific device is the i2c part.  This
>>>   would achieve two things:
>>>    * all i2c devices would have the common fields at the beggining
>>>    * we sent the data for one device in one go, so we will never had
>>>      trouble making sure that both devices arrive at the same time, in
>>>      the right order, etc.
>>>
>>> - I guess there is same reasy why you want to split the device state,
>>>   it could be on the other series where I haven't read it though.
>
> So this is exactly what I have done in the SSI. Correct me if I am
> wrong but it is the same setup as PCI where the VMSTATE_PCI_DEVICE
> (VMSTATE_SSI_SLAVE in my case) is the first field. All I need to do is
> bump version numbers?

I think so.  What boards normally use SSI?

Later, Juan.