From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T10VJ-00022Z-Bv for qemu-devel@nongnu.org; Mon, 13 Aug 2012 15:40:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T10VG-0001K1-4A for qemu-devel@nongnu.org; Mon, 13 Aug 2012 15:40:45 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:44457) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T10VF-0001Jo-Rx for qemu-devel@nongnu.org; Mon, 13 Aug 2012 15:40:41 -0400 Received: from /spool/local by e1.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 13 Aug 2012 15:40:40 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 6BE5F6E8063 for ; Mon, 13 Aug 2012 15:37:20 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7DJbJa9149118 for ; Mon, 13 Aug 2012 15:37:19 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7DJbFmQ014471 for ; Mon, 13 Aug 2012 16:37:19 -0300 From: Anthony Liguori In-Reply-To: <20120813161833.72e1609e@doriath.home> References: <1344614655-2195-1-git-send-email-aliguori@us.ibm.com> <20120813141658.1bc8b15e@doriath.home> <20120813161833.72e1609e@doriath.home> Date: Mon, 13 Aug 2012 14:37:10 -0500 Message-ID: <877gt237o9.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Peter Maydell , Alexander Graf , Eric Blake , qemu-devel@nongnu.org, Markus Armbruster Luiz Capitulino writes: > On Mon, 13 Aug 2012 14:16:58 -0300 > Luiz Capitulino wrote: > >> On Fri, 10 Aug 2012 11:04:08 -0500 >> Anthony Liguori wrote: >>=20 >> > This series implements the necessary commands to implements danpb's id= ea to >> > remove -help parsing in libvirt. We would introduce all of these comm= ands in >> > 1.2 and then change the -help output starting in 1.3. >>=20 >> Applied to the qmp branch, thanks. > > Hmm, this series broke ppc-softmmu for me: Curious, I'll look into that. Thanks Regards, Anthony Liguori > > In file included from /home/lcapitulino/work/src/qmp-unstable/target-ppc/= translate_init.c:30:0, > from /home/lcapitulino/work/src/qmp-unstable/target-ppc/= translate.c:9404: > ../qmp-commands.h:23:1: error: unknown type name =E2=80=98QDict=E2=80=99 > ../qmp-commands.h:23:68: error: unknown type name =E2=80=98QObject=E2=80= =99 > > But it's not its fault. The problem here is probably a patch in my error > series that is doing header cleanup and qmp-commands.h was probably relyi= ng > on qapi-types.h (or some of its include files) including qdict.h. > > I'm going to include the following patch in my pull request: > > Subject: [PATCH 36/48] scripts: qapi-commands.py: qmp-commands.h: include > qdict.h > > qmp-commands.h declares several functions that have arguments of > type QDict. However, qdict.h is not included. This will cause a > build breakage when a file includes qmp-commands.h but doesn't > include qdict.h. > > Signed-off-by: Luiz Capitulino > --- > scripts/qapi-commands.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py > index 9eed40e..3c4678d 100644 > --- a/scripts/qapi-commands.py > +++ b/scripts/qapi-commands.py > @@ -342,6 +342,7 @@ def gen_command_decl_prologue(header, guard, prefix= =3D""): > #define %(guard)s >=20=20 > #include "%(prefix)sqapi-types.h" > +#include "qdict.h" > #include "error.h" >=20=20 > ''', > --=20 > 1.7.11.2.249.g31c7954.dirty