From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvvmR-0002Rb-Pg for qemu-devel@nongnu.org; Mon, 30 Jul 2012 15:37:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SvvmQ-00048b-Kl for qemu-devel@nongnu.org; Mon, 30 Jul 2012 15:37:27 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.142]:44219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvvmQ-00048W-GV for qemu-devel@nongnu.org; Mon, 30 Jul 2012 15:37:26 -0400 Received: from /spool/local by e2.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 30 Jul 2012 15:37:25 -0400 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id F083338C803B for ; Mon, 30 Jul 2012 15:37:19 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6UJbJk31311174 for ; Mon, 30 Jul 2012 15:37:19 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6V18A4M016657 for ; Mon, 30 Jul 2012 21:08:12 -0400 From: Anthony Liguori In-Reply-To: <87zk6h3vy4.fsf@trasno.org> References: <1343554983-4195-1-git-send-email-owasserm@redhat.com> <1343554983-4195-3-git-send-email-owasserm@redhat.com> <87zk6h3vy4.fsf@trasno.org> Date: Mon, 30 Jul 2012 14:37:02 -0500 Message-ID: <877gtl59cx.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com, Orit Wasserman Cc: peter.maydell@linaro.org, stefanha@gmail.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, chegu_vinod@hp.com, avi@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, eblake@redhat.com Juan Quintela writes: > Orit Wasserman wrote: >> The management can enable/disable a capability for the next migration by using >> migrate_set_parameter command. >> The management can query the current migration capabilities using >> query-migrate-parameters >> >> Signed-off-by: Orit Wasserman >> Signed-off-by: Juan Quintela > > I just noticed .... shouldn't we use > > migrate_set_parameter cache_size 256M > ??? > > I think that even the old migration parameters could be added to this > one? > > migrate_set_parameter downtime 30ms > migrate_set_parameter bandwidth 1G > > This way everything would be more regular, and easier on libvirt, as new > parameters would be trivial to ask for? > > Notice that I can understand that we have to maintain the old commands > for compability, but we can do "regularly" for new ones? I think this is worse. How does libvirt determine which parameters are valid? Let's do migrate_set_cache_size. Please don't introduce commands that multiplex multiple behavior. They do more harm than good. Regards, Anthony Liguori > > Later, Juan.