From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScKMV-0001eB-HB for qemu-devel@nongnu.org; Wed, 06 Jun 2012 13:49:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScKMP-0004j7-43 for qemu-devel@nongnu.org; Wed, 06 Jun 2012 13:49:39 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:33733) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScKMO-0004iS-Gm for qemu-devel@nongnu.org; Wed, 06 Jun 2012 13:49:33 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 Jun 2012 23:19:24 +0530 Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q56HnMhk8978818 for ; Wed, 6 Jun 2012 23:19:23 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q56NIdg0007207 for ; Thu, 7 Jun 2012 09:18:39 +1000 From: "Aneesh Kumar K.V" In-Reply-To: <20120224195143.GA16353@vostro.hallyn.com> References: <20120224195143.GA16353@vostro.hallyn.com>User-Agent: Notmuch/0.11.1+346~g13d19c3 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Wed, 06 Jun 2012 23:19:20 +0530 Message-ID: <877gvknxen.fsf@skywalker.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] virtio-9p-handle: define AT_EMPTY_PATH if needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Hallyn , qemu-devel@nongnu.org, aliguori@us.ibm.com Serge Hallyn writes: > If AT_EMPTY_PATH is not in one of the included files, go ahead and > define it. qemu won't compile on ubuntu for me without this. > > (Note - alternatively we could #include to pick > up the definitions there) Then why don't we do that ? I do get the below errors In file included from /usr/include/x86_64-linux-gnu/asm/fcntl.h:1:0, from /usr/include/linux/fcntl.h:4, from /home/opensource/sources/qemu/qemu-upstream/hw/9pfs/v= irtio-9p-handle.c:28: /usr/include/asm-generic/fcntl.h:127:8: error: redefinition of =E2=80=98str= uct f_owner_ex=E2=80=99 /usr/include/x86_64-linux-gnu/bits/fcntl.h:204:8: note: originally defined = here In file included from /usr/include/x86_64-linux-gnu/asm/fcntl.h:1:0, from /usr/include/linux/fcntl.h:4, Are they do to ubuntu multi-arch changes ?=20 > > Signed-off-by: Serge Hallyn > --- > hw/9pfs/virtio-9p-handle.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/hw/9pfs/virtio-9p-handle.c b/hw/9pfs/virtio-9p-handle.c > index f96d17a..e403a84 100644 > --- a/hw/9pfs/virtio-9p-handle.c > +++ b/hw/9pfs/virtio-9p-handle.c > @@ -39,6 +39,15 @@ > #ifndef BTRFS_SUPER_MAGIC > #define BTRFS_SUPER_MAGIC 0x9123683E > #endif > +#ifndef AT_REMOVEDIR > +#define AT_REMOVEDIR 0x200 > +#endif > +#ifndef AT_EMPTY_PATH > +#define AT_EMPTY_PATH 0x1000 /* Allow empty relative pathname */ > +#endif > +#ifndef O_PATH > +#define O_PATH 010000000 > +#endif > > struct handle_data { > int mountfd; > --=20 > 1.7.9 -aneesh