Re: [Qemu-devel] [PATCH 12/22] virtio-9p: avoid unwarranted use of strncpy

["Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>]

Jim Meyering <jim@meyering.net> writes:

> From: Jim Meyering <meyering@redhat.com>
>
> The use of strncpy in mp_user_listxattr is unnecessary, since we
> know that the NUL-terminated source bytes fit in the destination
> buffer.  Use memcpy in place of strncpy.
>
> Signed-off-by: Jim Meyering <meyering@redhat.com>


May be this can be folded into the earlier patch ?

Reviewed-by: Aneeseh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>


> ---
>  hw/9pfs/virtio-9p-xattr-user.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/9pfs/virtio-9p-xattr-user.c b/hw/9pfs/virtio-9p-xattr-user.c
> index 5044a3e..5bb6020 100644
> --- a/hw/9pfs/virtio-9p-xattr-user.c
> +++ b/hw/9pfs/virtio-9p-xattr-user.c
> @@ -61,7 +61,8 @@ static ssize_t mp_user_listxattr(FsContext *ctx, const char *path,
>          return -1;
>      }
>
> -    strncpy(value, name, name_size);
> +    /* name_size includes the trailing NUL. */
> +    memcpy(value, name, name_size);
>      return name_size;
>  }
>
> -- 
> 1.7.10.1.487.ga3935e6