* [RFC PATCH] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot
@ 2024-08-01 17:23 Philippe Mathieu-Daudé
2024-08-05 6:54 ` Yoshinori Sato
2024-08-05 12:39 ` Alex Bennée
0 siblings, 2 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-08-01 17:23 UTC (permalink / raw)
To: qemu-devel
Cc: Cleber Rosa, Wainer dos Santos Moschetta, Beraldo Leal,
Stefan Hajnoczi, Alex Bennée, Philippe Mathieu-Daudé,
Yoshinori Sato, Richard Henderson
We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
rationalise unstable gitlab tests under FLAKY_TESTS") for
being flaky. However I don't recall the U-Boot test to fail
(the problematic line checking the 'version' string is already
commented out), and I'm running this test reliably, so re-enable
it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
tests/avocado/machine_rx_gdbsim.py | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/avocado/machine_rx_gdbsim.py b/tests/avocado/machine_rx_gdbsim.py
index 412a7a5089..a83873b738 100644
--- a/tests/avocado/machine_rx_gdbsim.py
+++ b/tests/avocado/machine_rx_gdbsim.py
@@ -22,8 +22,6 @@ class RxGdbSimMachine(QemuSystemTest):
timeout = 30
KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 '
- @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab')
-
def test_uboot(self):
"""
U-Boot and checks that the console is operational.
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [RFC PATCH] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot
2024-08-01 17:23 [RFC PATCH] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot Philippe Mathieu-Daudé
@ 2024-08-05 6:54 ` Yoshinori Sato
2024-08-05 12:41 ` Philippe Mathieu-Daudé
2024-08-05 12:39 ` Alex Bennée
1 sibling, 1 reply; 5+ messages in thread
From: Yoshinori Sato @ 2024-08-05 6:54 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel, Cleber Rosa, Wainer dos Santos Moschetta,
Beraldo Leal, Stefan Hajnoczi, Alex Bennée,
Richard Henderson
On Fri, 02 Aug 2024 02:23:32 +0900,
Philippe Mathieu-Daudé wrote:
>
> We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
> rationalise unstable gitlab tests under FLAKY_TESTS") for
> being flaky. However I don't recall the U-Boot test to fail
> (the problematic line checking the 'version' string is already
> commented out), and I'm running this test reliably, so re-enable
> it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> tests/avocado/machine_rx_gdbsim.py | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tests/avocado/machine_rx_gdbsim.py b/tests/avocado/machine_rx_gdbsim.py
> index 412a7a5089..a83873b738 100644
> --- a/tests/avocado/machine_rx_gdbsim.py
> +++ b/tests/avocado/machine_rx_gdbsim.py
> @@ -22,8 +22,6 @@ class RxGdbSimMachine(QemuSystemTest):
> timeout = 30
> KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 '
>
> - @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab')
> -
> def test_uboot(self):
> """
> U-Boot and checks that the console is operational.
> --
> 2.45.2
>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
--
Yosinori Sato
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [RFC PATCH] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot
2024-08-05 6:54 ` Yoshinori Sato
@ 2024-08-05 12:41 ` Philippe Mathieu-Daudé
2024-08-05 12:56 ` Alex Bennée
0 siblings, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-08-05 12:41 UTC (permalink / raw)
To: Yoshinori Sato
Cc: qemu-devel, Cleber Rosa, Wainer dos Santos Moschetta,
Beraldo Leal, Stefan Hajnoczi, Alex Bennée,
Richard Henderson
On 5/8/24 08:54, Yoshinori Sato wrote:
> On Fri, 02 Aug 2024 02:23:32 +0900,
> Philippe Mathieu-Daudé wrote:
>>
>> We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
>> rationalise unstable gitlab tests under FLAKY_TESTS") for
>> being flaky. However I don't recall the U-Boot test to fail
>> (the problematic line checking the 'version' string is already
>> commented out), and I'm running this test reliably, so re-enable
>> it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> tests/avocado/machine_rx_gdbsim.py | 2 --
>> 1 file changed, 2 deletions(-)
> Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Thanks, I'll queue this patch for 9.2 to avoid messing
with the next release.
Regards,
Phil.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [RFC PATCH] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot
2024-08-05 12:41 ` Philippe Mathieu-Daudé
@ 2024-08-05 12:56 ` Alex Bennée
0 siblings, 0 replies; 5+ messages in thread
From: Alex Bennée @ 2024-08-05 12:56 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Yoshinori Sato, qemu-devel, Cleber Rosa,
Wainer dos Santos Moschetta, Beraldo Leal, Stefan Hajnoczi,
Richard Henderson
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> On 5/8/24 08:54, Yoshinori Sato wrote:
>> On Fri, 02 Aug 2024 02:23:32 +0900,
>> Philippe Mathieu-Daudé wrote:
>>>
>>> We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
>>> rationalise unstable gitlab tests under FLAKY_TESTS") for
>>> being flaky. However I don't recall the U-Boot test to fail
>>> (the problematic line checking the 'version' string is already
>>> commented out), and I'm running this test reliably, so re-enable
>>> it.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> ---
>>> tests/avocado/machine_rx_gdbsim.py | 2 --
>>> 1 file changed, 2 deletions(-)
>
>> Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
>
> Thanks, I'll queue this patch for 9.2 to avoid messing
> with the next release.
Testing updates are usually fine, but I can leave it to you to merge if
you prefer.
>
> Regards,
>
> Phil.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot
2024-08-01 17:23 [RFC PATCH] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot Philippe Mathieu-Daudé
2024-08-05 6:54 ` Yoshinori Sato
@ 2024-08-05 12:39 ` Alex Bennée
1 sibling, 0 replies; 5+ messages in thread
From: Alex Bennée @ 2024-08-05 12:39 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel, Cleber Rosa, Wainer dos Santos Moschetta,
Beraldo Leal, Stefan Hajnoczi, Yoshinori Sato, Richard Henderson
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
> rationalise unstable gitlab tests under FLAKY_TESTS") for
> being flaky. However I don't recall the U-Boot test to fail
> (the problematic line checking the 'version' string is already
> commented out), and I'm running this test reliably, so re-enable
> it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Queued to for-9.1/misc-fixes, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-08-05 12:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-01 17:23 [RFC PATCH] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot Philippe Mathieu-Daudé
2024-08-05 6:54 ` Yoshinori Sato
2024-08-05 12:41 ` Philippe Mathieu-Daudé
2024-08-05 12:56 ` Alex Bennée
2024-08-05 12:39 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).