From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 517B2C4332F for ; Tue, 7 Nov 2023 10:26:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0JGV-0006jG-SO; Tue, 07 Nov 2023 05:25:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0JGU-0006dp-JT for qemu-devel@nongnu.org; Tue, 07 Nov 2023 05:24:58 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0JGQ-0005Li-1M for qemu-devel@nongnu.org; Tue, 07 Nov 2023 05:24:58 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4084e49a5e5so47326395e9.3 for ; Tue, 07 Nov 2023 02:24:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699352692; x=1699957492; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GInYU+a471jFy9YHr5yaV8k5tH981lem8wwS+q0VfyE=; b=W3z9brAW8wzP3vaNj7VFqUYiuE36xj/exPkOc8ZWYq8JGowriLqF9zR+aTqwnm5stq sjKV35YvhCoodLAe+Lx1/VJrjdGsSqb4WLA2cYP06jmpiI9S7wjpIRtPFGghQsbO4LBn iJ0f5GCLPVLiSIc2W9/a0dTcBSMOIuexMIDldKKzL8dfod9VlscQlYHPlo5ua/IdUXsj sr9i3nF5BrbW8JV84VlWLWvT1L4uKV3NXD4nbLPvgo+G5h83K396FmBRGuFTcadTKyRq ToR9Si5q3CvXaV7m6mF0X1NFZF7ulo4kj4ttkw8ut7ikBELhDY1GZXOiY3GAQv/JXVYO 6yVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699352692; x=1699957492; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GInYU+a471jFy9YHr5yaV8k5tH981lem8wwS+q0VfyE=; b=RhPa3maaF9ABNuxjSU1Pt7pQCA04JOfvjiIqt7vtlBqfuPWzFn/Z858KJDhsJvBhfP 1/J9NTB3/KzV8maSEw/o5vmqlXjgapkxRU89QTj488k/jXwlc0a4k1NOQ4SCaeF8uh4m qThbYSnDohxNJk7FRjOv/Z3fPejUHVgGGXLnxOurTK1sv6SvdlpHy9VHxYhxw4tDPqju 3fPRasJylsTPHchQ1t265fw9p3Y/1+Ljhj3zNuyra0RRVM12vvGnAYwdRBlQlxaXJVKM qgQwX+KXTTWIDdlHK2oagWYLmn0dIXMPFahl9co5NnoDnS9Do6hnV2vE9IdjXn9Mh1JV qQ7g== X-Gm-Message-State: AOJu0Yyhy591AMZQNUGGSmroJ7vI2MWVtL8Mu+Qj7rRp0jmnESw+zCTI caq5ZJprY4E3Fc+qEU5y2+vO+Q== X-Google-Smtp-Source: AGHT+IHr33KgC8suokQMrsHXhXWcdCLOGw/LSSeaN3viLNw02DlwgN6wNIgIG98Wyq+SWVm0+n/Z6g== X-Received: by 2002:a05:600c:19c8:b0:401:be5a:989 with SMTP id u8-20020a05600c19c800b00401be5a0989mr1896154wmq.23.1699352692359; Tue, 07 Nov 2023 02:24:52 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id je3-20020a05600c1f8300b004083bc9ac90sm15280611wmb.24.2023.11.07.02.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 02:24:52 -0800 (PST) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 7F7485F790; Tue, 7 Nov 2023 10:24:51 +0000 (GMT) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, Peter Maydell , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Laurent Vivier , Mahmoud Mandour , Cleber Rosa , Wainer dos Santos Moschetta , Paolo Bonzini , Thomas Huth , Beraldo Leal , Alexandre Iooss , John Snow , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Chris Wulff , Marek Vasut , Richard Henderson , Akihiko Odaki Subject: Re: [PATCH 08/22] gdbstub: Add num_regs member to GDBFeature In-Reply-To: <3bf96059-44a8-4af3-9b0b-c9f070cd498b@linaro.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Tue, 7 Nov 2023 11:07:11 +0100 (15 minutes, 33 seconds ago)") References: <20231106185112.2755262-1-alex.bennee@linaro.org> <20231106185112.2755262-9-alex.bennee@linaro.org> <3bf96059-44a8-4af3-9b0b-c9f070cd498b@linaro.org> User-Agent: mu4e 1.11.24; emacs 29.1 Date: Tue, 07 Nov 2023 10:24:51 +0000 Message-ID: <878r797te4.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Philippe Mathieu-Daud=C3=A9 writes: > Hi Alex, > > On 6/11/23 19:50, Alex Benn=C3=A9e wrote: >> From: Akihiko Odaki >> Currently the number of registers exposed to GDB is written as magic >> numbers in code. Derive the number of registers GDB actually see from >> XML files to replace the magic numbers in code later. >> Signed-off-by: Akihiko Odaki >> Reviewed-by: Philippe Mathieu-Daud=C3=A9 >> Reviewed-by: Alex Benn=C3=A9e >> Message-Id: <20231025093128.33116-2-akihiko.odaki@daynix.com> > > Something in your workflow is odd, you should keep this Message-Id, > >> Signed-off-by: Alex Benn=C3=A9e >> Message-Id: <20231103195956.1998255-9-alex.bennee@linaro.org> > > and not propagate this one, IMO. Why not - it tracks all the review stuff. I explicitly keep on Message-Id per domain so we see the original posting and the last time it was posted (which you can then follow the chain of reviews from there). If we want to have an explicit policy on which Message-Id's to keep then we should document it. --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro