From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92D4ECDB465 for ; Sat, 14 Oct 2023 15:10:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrgHO-00078t-3H; Sat, 14 Oct 2023 11:10:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrgHL-000782-T3 for qemu-devel@nongnu.org; Sat, 14 Oct 2023 11:10:11 -0400 Received: from hsmtpd-def.xspmail.jp ([202.238.198.244]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrgHK-0001lH-LY for qemu-devel@nongnu.org; Sat, 14 Oct 2023 11:10:11 -0400 X-Country-Code: JP Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) by hsmtpd-out-1.asahinet.cluster.xspmail.jp (Halon) with ESMTPA id 40883065-4f67-448e-8850-1d8cd048bc9f; Sun, 15 Oct 2023 00:10:07 +0900 (JST) Received: from SIOS1075.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id 3099C1C0037; Sun, 15 Oct 2023 00:10:07 +0900 (JST) Date: Sun, 15 Oct 2023 00:10:06 +0900 Message-ID: <878r858ckx.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Magnus Damm , qemu-trivial@nongnu.org Subject: Re: [PATCH 3/3] hw/pci-host/sh_pcic: Replace magic value by proper definition In-Reply-To: <20231012041237.22281-4-philmd@linaro.org> References: <20231012041237.22281-1-philmd@linaro.org> <20231012041237.22281-4-philmd@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Received-SPF: softfail client-ip=202.238.198.244; envelope-from=ysato@users.sourceforge.jp; helo=hsmtpd-def.xspmail.jp X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, 12 Oct 2023 13:12:37 +0900, Philippe Mathieu-Daud=E9 wrote: >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 Reviewed-by: Yoshinori Sato > --- > hw/pci-host/sh_pci.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/pci-host/sh_pci.c b/hw/pci-host/sh_pci.c > index 580e273d96..4edebced5e 100644 > --- a/hw/pci-host/sh_pci.c > +++ b/hw/pci-host/sh_pci.c > @@ -40,7 +40,7 @@ struct SHPCIState { > PCIHostState parent_obj; > =20 > PCIDevice *dev; > - qemu_irq irq[4]; > + qemu_irq irq[PCI_NUM_PINS]; > MemoryRegion memconfig_p4; > MemoryRegion memconfig_a7; > MemoryRegion isa; > @@ -131,7 +131,8 @@ static void sh_pcic_host_realize(DeviceState *dev, Er= ror **errp) > s->irq, > get_system_memory(), > get_system_io(), > - PCI_DEVFN(0, 0), 4, TYPE_PCI_BUS); > + PCI_DEVFN(0, 0), PCI_NUM_PINS, > + TYPE_PCI_BUS); > memory_region_init_io(&s->memconfig_p4, OBJECT(s), &sh_pci_reg_ops, = s, > "sh_pci", 0x224); > memory_region_init_alias(&s->memconfig_a7, OBJECT(s), "sh_pci.2", > --=20 > 2.41.0 >=20