From: Fabiano Rosas <farosas@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, "Laurent Vivier" <lvivier@redhat.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Helge Deller" <deller@gmx.de>,
"Xiaojuan Yang" <yangxiaojuan@loongson.cn>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Juan Quintela" <quintela@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Cédric Le Goater" <clg@kaod.org>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Andrew Jeffery" <andrew@aj.id.au>,
qemu-s390x@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-arm@nongnu.org,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Beraldo Leal" <bleal@redhat.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Radoslaw Biernacki" <rad@semihalf.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"David Hildenbrand" <david@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Song Gao" <gaosong@loongson.cn>, "Joel Stanley" <joel@jms.id.au>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine
Date: Thu, 04 May 2023 09:56:13 -0300 [thread overview]
Message-ID: <878re4cl1u.fsf@suse.de> (raw)
In-Reply-To: <e7185f74-f041-05b1-0f76-bab6d724e796@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 5/3/23 20:32, Peter Maydell wrote:
>> Do we really want to build a QEMU that then barfs unless
>> you pass -nodefaults, though ? That doesn't seem very useful.
>> Something somewhere ought to be saying "if you want the
>> virt board then you almost certainly want these".
>
> Well, the point is that --without-default-devices is intended to be for
> people that write their device config by hand.
>
It's a bit hard to maintain the original intention with just
documentation. Couldn't we require that --without-default-devices always
be accompanied by --with-devices? And more to the point of Peter's
question, couldn't we just leave the defaults off unconditionally when
--without-default-devices is passed without --with-devices?
The coupling of -nodefaults with --without-default-devices is a bit
redundant. If we're choosing to not build some devices, then the QEMU
binary should already know that.
Just to be clear, -nodefaults by itself still makes sense because we can
have a simple command line for those using QEMU directly while allowing
the management layer to fine tune the devices.
In the long run, I think we need to add some configure option that gives
us pure allnoconfig so we can have that in the CI and catch these CONFIG
issues before merging. There's no reason to merge a new CONFIG if it
will then be impossible to turn it off.
next prev parent reply other threads:[~2023-05-04 17:44 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 9:12 [PATCH 00/22] testing/next: cirrus, docker, docs, ci, configs, gitlab Alex Bennée
2023-05-03 9:12 ` [PATCH 01/22] gitlab/cirrus: reduce scope of the FreeBSD testing matrix Alex Bennée
2023-05-03 9:18 ` Thomas Huth
2023-05-03 9:12 ` [PATCH 02/22] tests/docker: bump the xtensa base to debian:11-slim Alex Bennée
2023-05-03 9:20 ` Thomas Huth
2023-05-03 10:28 ` Juan Quintela
2023-05-03 9:12 ` [PATCH 03/22] docs: document breakpoint and watchpoint support Alex Bennée
2023-05-03 10:30 ` Juan Quintela
2023-05-03 9:12 ` [PATCH 04/22] scripts/ci: add gitlab-runner to kvm group Alex Bennée
2023-05-03 9:22 ` Thomas Huth
2023-05-03 10:15 ` Richard Henderson
2023-05-03 9:12 ` [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine Alex Bennée
2023-05-03 10:17 ` Richard Henderson
2023-05-03 14:00 ` Paolo Bonzini
2023-05-03 14:46 ` Fabiano Rosas
2023-05-03 15:35 ` Alex Bennée
2023-05-03 17:05 ` Paolo Bonzini
2023-05-03 18:32 ` Peter Maydell
2023-05-04 6:56 ` Thomas Huth
2023-05-04 7:09 ` Alex Bennée
2023-05-04 7:16 ` Paolo Bonzini
2023-05-04 12:56 ` Fabiano Rosas [this message]
2023-05-08 22:23 ` Paolo Bonzini
2023-05-09 9:27 ` Peter Maydell
2023-05-09 9:42 ` Paolo Bonzini
2023-05-09 10:00 ` Peter Maydell
2023-05-09 10:53 ` Paolo Bonzini
2023-05-09 11:37 ` Alex Bennée
2023-05-09 11:59 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 06/22] hw/arm: Select VIRTIO_BLK " Alex Bennée
2023-05-03 10:17 ` Richard Henderson
2023-05-03 10:31 ` Juan Quintela
2023-05-03 17:21 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 07/22] hw/arm: Select XLNX_USB_SUBSYS for xlnx-zcu102 machine Alex Bennée
2023-05-03 10:18 ` Richard Henderson
2023-05-03 17:07 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 08/22] hw/arm: Select GICV3_TCG for sbsa-ref machine Alex Bennée
2023-05-03 10:19 ` Richard Henderson
2023-05-03 17:22 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 09/22] hw/arm: Select e1000e " Alex Bennée
2023-05-03 10:20 ` Richard Henderson
2023-05-03 17:13 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 10/22] hw/arm: Select VGA_PCI " Alex Bennée
2023-05-03 10:21 ` Richard Henderson
2023-05-03 9:12 ` [PATCH 11/22] hw/alpha: make E1000_PCI a hard dependency for clipper Alex Bennée
2023-05-03 10:26 ` Richard Henderson
2023-05-03 17:14 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 12/22] hw/hppa: add TULIP as a dependency for HPPA_B160L Alex Bennée
2023-05-03 10:26 ` Richard Henderson
2023-05-03 17:15 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 13/22] hw/sparc: add a TCX dependency for SUN4M machines Alex Bennée
2023-05-03 10:27 ` Richard Henderson
2023-05-03 17:17 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 14/22] hw/loongarch: add VIRTIO as a dependency for LOONGARCH_VIRT Alex Bennée
2023-05-03 10:27 ` Richard Henderson
2023-05-03 17:18 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 15/22] hw/sh4: make RTL8139 a hard dependency for RD2 Alex Bennée
2023-05-03 10:27 ` Richard Henderson
2023-05-03 17:19 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 16/22] hw/mips: add VIRTIO and USB dependencies for LOONGSON3V Alex Bennée
2023-05-03 17:20 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 17/22] hw/xtensa: add VIRTIO as dependencies for XTENSA_VIRT Alex Bennée
2023-05-03 10:28 ` Richard Henderson
2023-05-03 14:14 ` Max Filippov
2023-05-03 17:20 ` Paolo Bonzini
2023-05-03 9:12 ` [PATCH 18/22] scripts/ci: clean-up the 20.04/22.04 confusion in ansible Alex Bennée
2023-05-03 9:12 ` [PATCH 19/22] gitlab: add ubuntu-22.04-aarch64-without-defaults Alex Bennée
2023-05-03 9:34 ` Thomas Huth
2023-05-03 10:29 ` Richard Henderson
2023-05-03 9:12 ` [PATCH 20/22] gitlab: enable minimal device profoile for aarch64 --disable-tcg Alex Bennée
2023-05-03 10:30 ` Richard Henderson
2023-05-03 10:34 ` Juan Quintela
2023-05-03 13:01 ` Fabiano Rosas
2023-05-03 9:12 ` [PATCH 21/22] tests/avocado: use http for mipsdistros.mips.com Alex Bennée
2023-05-03 9:43 ` Thomas Huth
2023-05-03 10:31 ` Richard Henderson
2023-05-10 7:12 ` Jiaxun Yang
2023-05-03 9:12 ` [PATCH 22/22] tests/qtest: skip bcm2835-test if no raspi3b model Alex Bennée
2023-05-03 9:51 ` Thomas Huth
2023-05-03 10:34 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878re4cl1u.fsf@suse.de \
--to=farosas@suse.de \
--cc=alex.bennee@linaro.org \
--cc=andrew@aj.id.au \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=clg@kaod.org \
--cc=crosa@redhat.com \
--cc=david@redhat.com \
--cc=deller@gmx.de \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=gaosong@loongson.cn \
--cc=iii@linux.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=joel@jms.id.au \
--cc=jsnow@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=quintela@redhat.com \
--cc=rad@semihalf.com \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=yangxiaojuan@loongson.cn \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).