From: Juan Quintela <quintela@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v2] test: Fix test-crypto-secret when compiling without keyring support
Date: Fri, 14 Apr 2023 13:43:43 +0200 [thread overview]
Message-ID: <878reug040.fsf@secure.mitica> (raw)
In-Reply-To: <849e915d-8628-9bd1-1b6b-9861027fcd3a@redhat.com> (Thomas Huth's message of "Tue, 11 Apr 2023 12:16:26 +0200")
Thomas Huth <thuth@redhat.com> wrote:
>> -#endif /* CONFIG_KEYUTILS */
>> +#endif /* CONFIG_SECRET_KEYRING */
>
> Nit: The comment after the "#endif" should mention both switches now,
> like the one earlier in the patch.
You are right.
Sent next version with it included.
Later, Juan.
prev parent reply other threads:[~2023-04-14 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 9:51 [PATCH v2] test: Fix test-crypto-secret when compiling without keyring support Juan Quintela
2023-04-11 10:16 ` Thomas Huth
2023-04-14 11:43 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878reug040.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).