From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-s390x@nongnu.org, David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v1] s390x/tcg: fix and optimize SPX (SET PREFIX)
Date: Fri, 06 Aug 2021 13:17:32 +0200 [thread overview]
Message-ID: <878s1ezusz.fsf@redhat.com> (raw)
In-Reply-To: <20210805125938.74034-1-david@redhat.com>
On Thu, Aug 05 2021, David Hildenbrand <david@redhat.com> wrote:
> We not only invalidate the translation of the range 0x0-0x2000, we also
> invalidate the translation of the new prefix range and the translation
> of the old prefix range -- because real2abs would return different
> results for all of these ranges when changing the prefix location.
>
> This fixes the kvm-unit-tests "edat" test that just hangs before this
> patch because we end up clearing the new prefix area instead of the old
> prefix area.
>
> While at it, let's not do anything in case the prefix doesn't change.
>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Cc: qemu-s390x@nongnu.org
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/tcg/misc_helper.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
Is this still -rc material? Especially as we are late in the -rc cycle
already.
next prev parent reply other threads:[~2021-08-06 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 12:59 [PATCH v1] s390x/tcg: fix and optimize SPX (SET PREFIX) David Hildenbrand
2021-08-05 13:44 ` Claudio Imbrenda
2021-08-06 5:21 ` Thomas Huth
2021-08-06 11:17 ` Cornelia Huck [this message]
2021-08-06 11:30 ` David Hildenbrand
2021-08-10 12:25 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s1ezusz.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).