* [PATCH] freebsd: use python37
@ 2020-01-06 12:37 Gerd Hoffmann
2020-01-06 13:19 ` Philippe Mathieu-Daudé
2020-01-07 11:11 ` Alex Bennée
0 siblings, 2 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2020-01-06 12:37 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Alex Bennée, Philippe Mathieu-Daudé,
Gerd Hoffmann
FreeBSD seems to use python37 by default now, which breaks the build
script. Add python to the package list, to explicitly pick the version,
and also adapt the configure command line.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
tests/vm/freebsd | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/vm/freebsd b/tests/vm/freebsd
index 1825cc58218b..33a736298a9a 100755
--- a/tests/vm/freebsd
+++ b/tests/vm/freebsd
@@ -32,6 +32,7 @@ class FreeBSDVM(basevm.BaseVM):
"git",
"pkgconf",
"bzip2",
+ "python37",
# gnu tools
"bash",
@@ -63,7 +64,7 @@ class FreeBSDVM(basevm.BaseVM):
mkdir src build; cd src;
tar -xf /dev/vtbd1;
cd ../build
- ../src/configure --python=python3.6 {configure_opts};
+ ../src/configure --python=python3.7 {configure_opts};
gmake --output-sync -j{jobs} {target} {verbose};
"""
--
2.18.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] freebsd: use python37
2020-01-06 12:37 [PATCH] freebsd: use python37 Gerd Hoffmann
@ 2020-01-06 13:19 ` Philippe Mathieu-Daudé
2020-01-06 13:21 ` Philippe Mathieu-Daudé
2020-01-07 11:11 ` Alex Bennée
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-06 13:19 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel; +Cc: Fam Zheng, Alex Bennée
On 1/6/20 1:37 PM, Gerd Hoffmann wrote:
> FreeBSD seems to use python37 by default now, which breaks the build
> script. Add python to the package list, to explicitly pick the version,
> and also adapt the configure command line.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> tests/vm/freebsd | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> index 1825cc58218b..33a736298a9a 100755
> --- a/tests/vm/freebsd
> +++ b/tests/vm/freebsd
> @@ -32,6 +32,7 @@ class FreeBSDVM(basevm.BaseVM):
> "git",
> "pkgconf",
> "bzip2",
> + "python37",
>
> # gnu tools
> "bash",
> @@ -63,7 +64,7 @@ class FreeBSDVM(basevm.BaseVM):
> mkdir src build; cd src;
> tar -xf /dev/vtbd1;
> cd ../build
> - ../src/configure --python=python3.6 {configure_opts};
> + ../src/configure --python=python3.7 {configure_opts};
> gmake --output-sync -j{jobs} {target} {verbose};
> """
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] freebsd: use python37
2020-01-06 13:19 ` Philippe Mathieu-Daudé
@ 2020-01-06 13:21 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-06 13:21 UTC (permalink / raw)
To: Gerd Hoffmann, QEMU Developers; +Cc: Fam Zheng, Alex Bennée
On Mon, Jan 6, 2020 at 2:19 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 1/6/20 1:37 PM, Gerd Hoffmann wrote:
> > FreeBSD seems to use python37 by default now, which breaks the build
BTW it looks clearer replacing by 'python3.7' here and in subject.
> > script. Add python to the package list, to explicitly pick the version,
> > and also adapt the configure command line.
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> > tests/vm/freebsd | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> > index 1825cc58218b..33a736298a9a 100755
> > --- a/tests/vm/freebsd
> > +++ b/tests/vm/freebsd
> > @@ -32,6 +32,7 @@ class FreeBSDVM(basevm.BaseVM):
> > "git",
> > "pkgconf",
> > "bzip2",
> > + "python37",
> >
> > # gnu tools
> > "bash",
> > @@ -63,7 +64,7 @@ class FreeBSDVM(basevm.BaseVM):
> > mkdir src build; cd src;
> > tar -xf /dev/vtbd1;
> > cd ../build
> > - ../src/configure --python=python3.6 {configure_opts};
> > + ../src/configure --python=python3.7 {configure_opts};
> > gmake --output-sync -j{jobs} {target} {verbose};
> > """
> >
> >
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] freebsd: use python37
2020-01-06 12:37 [PATCH] freebsd: use python37 Gerd Hoffmann
2020-01-06 13:19 ` Philippe Mathieu-Daudé
@ 2020-01-07 11:11 ` Alex Bennée
1 sibling, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2020-01-07 11:11 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Fam Zheng, Philippe Mathieu-Daudé, qemu-devel
Gerd Hoffmann <kraxel@redhat.com> writes:
> FreeBSD seems to use python37 by default now, which breaks the build
> script. Add python to the package list, to explicitly pick the version,
> and also adapt the configure command line.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Queued to testing/next, thanks.
> ---
> tests/vm/freebsd | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> index 1825cc58218b..33a736298a9a 100755
> --- a/tests/vm/freebsd
> +++ b/tests/vm/freebsd
> @@ -32,6 +32,7 @@ class FreeBSDVM(basevm.BaseVM):
> "git",
> "pkgconf",
> "bzip2",
> + "python37",
>
> # gnu tools
> "bash",
> @@ -63,7 +64,7 @@ class FreeBSDVM(basevm.BaseVM):
> mkdir src build; cd src;
> tar -xf /dev/vtbd1;
> cd ../build
> - ../src/configure --python=python3.6 {configure_opts};
> + ../src/configure --python=python3.7 {configure_opts};
> gmake --output-sync -j{jobs} {target} {verbose};
> """
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-07 11:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-06 12:37 [PATCH] freebsd: use python37 Gerd Hoffmann
2020-01-06 13:19 ` Philippe Mathieu-Daudé
2020-01-06 13:21 ` Philippe Mathieu-Daudé
2020-01-07 11:11 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).