From: "Alex Bennée" <alex.bennee@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Emilio G. Cota" <cota@braap.org>,
mttcg@listserver.greensocs.com, peter.maydell@linaro.org,
claudio.fontana@huawei.com, jan.kiszka@siemens.com,
mark.burton@greensocs.com, a.rigo@virtualopensystems.com,
qemu-devel@nongnu.org, serge.fdrv@gmail.com,
bobby.prani@gmail.com, rth@twiddle.net,
fred.konrad@greensocs.com
Subject: Re: [Qemu-devel] [PATCH v2 0/6] Reduce lock contention on TCG hot-path
Date: Thu, 07 Jul 2016 20:33:10 +0100 [thread overview]
Message-ID: <878txdmefd.fsf@linaro.org> (raw)
In-Reply-To: <21e93a61-c942-b503-c592-bc68b55454cd@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 07/07/2016 18:04, Emilio G. Cota wrote:
>>> > I think the first 3 patches are ready to take if the TCG maintainers
>>> > want to:
>>> >
>>> > tcg: Ensure safe tb_jmp_cache lookup out of 'tb_lock'
>>> > tcg: set up tb->page_addr before insertion
>>> > tcg: cpu-exec: remove tb_lock from the hot-path
>> I think it would be simpler to use tb_lock_recursive and
>> tb_lock_reset, as pointed out in v1 of this series.
>
> I agree, this series is doing a lot more restructuring than necessary.
Really I thought the first 3 patches where simplifying things - that's
why I moved the more aggressive stuff into follow on patches. Wouldn't
using tb_lock_recursive inside the mmap_lock() run the risk of a deadlock?
>
> Paolo
--
Alex Bennée
next prev parent reply other threads:[~2016-07-07 19:33 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 16:18 [Qemu-devel] [PATCH v2 0/6] Reduce lock contention on TCG hot-path Alex Bennée
2016-07-05 16:18 ` [Qemu-devel] [PATCH v2 1/6] tcg: Ensure safe tb_jmp_cache lookup out of 'tb_lock' Alex Bennée
2016-07-07 13:52 ` Sergey Fedorov
2016-07-08 14:51 ` Sergey Fedorov
2016-07-05 16:18 ` [Qemu-devel] [PATCH v2 2/6] tcg: set up tb->page_addr before insertion Alex Bennée
2016-07-07 14:08 ` Sergey Fedorov
2016-07-08 9:40 ` Sergey Fedorov
2016-07-05 16:18 ` [Qemu-devel] [PATCH v2 3/6] tcg: cpu-exec: remove tb_lock from the hot-path Alex Bennée
2016-07-07 14:18 ` Sergey Fedorov
2016-07-08 15:50 ` Sergey Fedorov
2016-07-08 17:34 ` Sergey Fedorov
2016-07-08 18:03 ` Alex Bennée
2016-07-08 18:20 ` Sergey Fedorov
2016-07-08 20:09 ` Sergey Fedorov
2016-07-05 16:18 ` [Qemu-devel] [PATCH v2 4/6] tcg: cpu-exec: factor out TB patching code Alex Bennée
2016-07-05 16:18 ` [Qemu-devel] [PATCH v2 5/6] tcg: introduce tb_lock_recursive() Alex Bennée
2016-07-05 16:18 ` [Qemu-devel] [PATCH v2 6/6] tcg: cpu-exec: roll-up tb_find_fast/slow Alex Bennée
2016-07-07 16:44 ` Sergey Fedorov
2016-07-07 16:44 ` [Qemu-devel] [PATCH 1/3] tcg: Introduce mmap_lock_reset() Sergey Fedorov
2016-07-07 16:44 ` [Qemu-devel] [PATCH 2/3] tcg: Introduce tb_lock_locked() Sergey Fedorov
2016-07-07 16:44 ` [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump() Sergey Fedorov
2016-07-07 19:36 ` Alex Bennée
2016-07-07 19:46 ` Sergey Fedorov
2016-07-07 20:36 ` Sergey Fedorov
2016-07-07 21:40 ` Alex Bennée
2016-07-08 8:40 ` Paolo Bonzini
2016-07-08 10:25 ` Sergey Fedorov
2016-07-08 11:02 ` Paolo Bonzini
2016-07-08 12:32 ` Sergey Fedorov
2016-07-08 14:07 ` Paolo Bonzini
2016-07-08 19:55 ` Sergey Fedorov
2016-07-08 20:18 ` Paolo Bonzini
2016-07-08 20:24 ` Sergey Fedorov
2016-07-08 20:52 ` Paolo Bonzini
2016-07-11 13:06 ` Sergey Fedorov
2016-07-11 14:03 ` Paolo Bonzini
2016-07-11 14:27 ` Sergey Fedorov
2016-07-07 16:04 ` [Qemu-devel] [PATCH v2 0/6] Reduce lock contention on TCG hot-path Emilio G. Cota
2016-07-07 16:13 ` Paolo Bonzini
2016-07-07 19:33 ` Alex Bennée [this message]
2016-07-07 19:38 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878txdmefd.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=a.rigo@virtualopensystems.com \
--cc=bobby.prani@gmail.com \
--cc=claudio.fontana@huawei.com \
--cc=cota@braap.org \
--cc=fred.konrad@greensocs.com \
--cc=jan.kiszka@siemens.com \
--cc=mark.burton@greensocs.com \
--cc=mttcg@listserver.greensocs.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=serge.fdrv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).