From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9vtB-0003x9-8V for qemu-devel@nongnu.org; Mon, 06 Jun 2016 10:52:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9vt7-0001Wp-63 for qemu-devel@nongnu.org; Mon, 06 Jun 2016 10:52:25 -0400 Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:35499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9vt6-0001Wh-VN for qemu-devel@nongnu.org; Mon, 06 Jun 2016 10:52:21 -0400 Received: by mail-wm0-x229.google.com with SMTP id c74so50091577wme.0 for ; Mon, 06 Jun 2016 07:52:20 -0700 (PDT) From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20160606121239.paubfta2c74epgfk@hawk.localdomain> Date: Mon, 06 Jun 2016 15:52:33 +0100 Message-ID: <878tyiid3i.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [kvm-unit-tests PATCH v2 01/10] lib: xstr: allow multiple args List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, andre.przywara@arm.com, peter.maydell@linaro.org, christoffer.dall@linaro.org, marc.zyngier@arm.com Andrew Jones writes: > On Mon, Jun 06, 2016 at 11:49:09AM +0100, Alex Bennée wrote: >> >> Andrew Jones writes: >> >> > Signed-off-by: Andrew Jones >> > --- >> > lib/libcflat.h | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/lib/libcflat.h b/lib/libcflat.h >> > index 582e3fc60e287..e5e588c742763 100644 >> > --- a/lib/libcflat.h >> > +++ b/lib/libcflat.h >> > @@ -27,8 +27,8 @@ >> > >> > #define __unused __attribute__((__unused__)) >> > >> > -#define xstr(s) xxstr(s) >> > -#define xxstr(s) #s >> > +#define xstr(s...) xxstr(s) >> > +#define xxstr(s...) #s >> >> OK my knowledge of stringinfication is still rusty despite having read >> the QEMU softmmu code. However: >> >> printf("Unknown subtest:" xstr(foo,ba) "\n"); >> >> Yields: >> >> Unknown subtestfoo,ba >> >> Is that what you wanted? Or were you aiming for xstr(foo,ba) => fooba > > The way I did it (which is like Linux) is what I wanted, see Linux's > version in include/linux/stringify.h. I can correct $SUBJECT to make > that more clear if you like. Linux seems to have multiple local definitions of these stringyfy operations so it is a little unclear. Any additional clarity in $SUBJECT is welcome ;-) > > Thanks, > drew > > > >> >> As an aside I couldn't actually see xstr being called with multiple >> arguments in the source tree. >> >> > >> > #define __ALIGN_MASK(x, mask) (((x) + (mask)) & ~(mask)) >> > #define __ALIGN(x, a) __ALIGN_MASK(x, (typeof(x))(a) - 1) >> >> >> -- >> Alex Bennée >> -- >> To unsubscribe from this list: send the line "unsubscribe kvm" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- Alex Bennée