From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41267)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ZvpBJ-00089g-EO
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 11:20:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ZvpBF-00032y-HW
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 11:20:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47439)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ZvpBF-00032u-CE
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 11:20:29 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1447053844-18102-1-git-send-email-den@openvz.org> (Denis
	V. Lunev's message of "Mon, 9 Nov 2015 10:24:04 +0300")
References: <563E16AF.8070209@openvz.org>
	<1447053844-18102-1-git-send-email-den@openvz.org>
Date: Mon, 09 Nov 2015 17:20:25 +0100
Message-ID: <878u679mba.fsf@emacs.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH for 2.5 v2 1/1] migration:
	qemu_savevm_state_cleanup becomes mandatory operation
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Amit Shah <amit.shah@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

"Denis V. Lunev" <den@openvz.org> wrote:
> since commit
>     commit 94f5a43704129ca4995aa3385303c5ae225bde42
>     Author: Liang Li <liang.z.li@intel.com>
>     Date:   Mon Nov 2 15:37:00 2015 +0800
>
>     migration: defer migration_end & blk_mig_cleanup
>
> when actual .cleanup callbacks calling was removed from complete operations.
>
> The patch fixes regression introduced by the commit above results in
> 100% reliable assert for virtio-scsi VM with iothreads enabled during
> 'virsh create-snapshot' operation:
>     assert(i != mr->ioeventfd_nb);
>     memory_region_del_eventfd
>     virtio_pci_set_host_notifier_internal
>     virtio_pci_set_host_notifier
>     virtio_scsi_dataplane_start
>     virtio_scsi_handle_cmd
>     virtio_queue_notify_vq
>     virtio_queue_host_notifier_read
>     aio_dispatch
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Reviewed-by: Liang Li <liang.z.li@intel.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Juan Quintela <quintela@redhat.com>
> CC: Amit Shah <amit.shah@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

And applied, thanks.