From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCVZJ-0001pV-UI for qemu-devel@nongnu.org; Tue, 07 Jul 2015 12:18:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCVZF-0005rs-Ue for qemu-devel@nongnu.org; Tue, 07 Jul 2015 12:18:01 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:36853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCVZF-0005re-OU for qemu-devel@nongnu.org; Tue, 07 Jul 2015 12:17:57 -0400 Received: by wgbgr6 with SMTP id gr6so18663820wgb.3 for ; Tue, 07 Jul 2015 09:17:57 -0700 (PDT) References: <1435330053-18733-1-git-send-email-fred.konrad@greensocs.com> <1435330053-18733-19-git-send-email-fred.konrad@greensocs.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1435330053-18733-19-git-send-email-fred.konrad@greensocs.com> Date: Tue, 07 Jul 2015 17:17:54 +0100 Message-ID: <878uas9c25.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH V6 18/18] translate-all: (wip) use tb_flush_safe when we can't alloc more tb. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com Cc: mttcg@listserver.greensocs.com, peter.maydell@linaro.org, a.spyridakis@virtualopensystems.com, mark.burton@greensocs.com, agraf@suse.de, qemu-devel@nongnu.org, guillaume.delbergue@greensocs.com, pbonzini@redhat.com, alistair.francis@xilinx.com fred.konrad@greensocs.com writes: > From: KONRAD Frederic > > This changes just the tb_flush called from tb_alloc. > > TODO: > * changes the other tb_flush. > > Signed-off-by: KONRAD Frederic > --- > translate-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/translate-all.c b/translate-all.c > index 8bd8fe8..9adaffa 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -1147,7 +1147,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu, > tb = tb_alloc(pc); > if (!tb) { > /* flush must be done */ > - tb_flush(env); > + tb_flush_safe(env); Hold on this is async right? What stops us rolling on and then getting flushed when the other vCPUs come to a halt? It deserves a comment at least. > /* cannot fail at this point */ > tb = tb_alloc(pc); > /* Don't forget to invalidate previous TB info. */ -- Alex Bennée