From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDDxB-000897-Da for qemu-devel@nongnu.org; Mon, 19 Jan 2015 10:09:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDDx5-0002Ze-1B for qemu-devel@nongnu.org; Mon, 19 Jan 2015 10:09:21 -0500 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:58409 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDDx4-0002ZA-Ru for qemu-devel@nongnu.org; Mon, 19 Jan 2015 10:09:14 -0500 References: <1421334118-3287-1-git-send-email-peter.maydell@linaro.org> <1421334118-3287-9-git-send-email-peter.maydell@linaro.org> <87iog3qgxg.fsf@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: Date: Mon, 19 Jan 2015 15:09:22 +0000 Message-ID: <878ugyren1.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 08/15] target-mips: Don't use _raw load/store accessors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Riku Voipio , QEMU Developers , Patch Tracking , Richard Henderson Peter Maydell writes: > On 19 January 2015 at 09:05, Alex Bennée wrote: >> >> Peter Maydell writes: >> >>> Use cpu_*_data instead of the direct *_raw load/store accessors. >> >> I take it this additional level of (macro) redirection is because at >> some point there will be a difference between the various cpu accessors? > > Which additional level of redirection? The point of this patch is > to remove a level of redirection (the _raw accessors), and at > the end of the series cpu_*_data aren't macros. Ahh I see. I haven't got that far yet as I'm still working through the glue() magic in the next few patches ;-) > > -- PMM -- Alex Bennée