From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmhRI-0002ZD-Pd for qemu-devel@nongnu.org; Fri, 07 Nov 2014 06:10:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XmhRE-00068A-6Z for qemu-devel@nongnu.org; Fri, 07 Nov 2014 06:10:48 -0500 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:47334 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmhRD-00066a-Ko for qemu-devel@nongnu.org; Fri, 07 Nov 2014 06:10:43 -0500 References: <36D1AB4E1AAC4541A1C88167C7231D0B74BAAD@G08CNEXMBPEKD02.g08.fujitsu.local> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <36D1AB4E1AAC4541A1C88167C7231D0B74BAAD@G08CNEXMBPEKD02.g08.fujitsu.local> Date: Fri, 07 Nov 2014 11:10:45 +0000 Message-ID: <878ujnnu4q.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] Add CMP2 instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Guo, Lei" Cc: "qemu-devel@nongnu.org" , "Wang, Chunping" Guo, Lei writes: > This patch aims to add CMP2 instruction for m68k family. > > Description: Compares the value in Rn to each bound. The effective address contains the > bounds pair: upper bound following the lower bound. For signed comparisons, the > arithmetically smaller value should be used as the lower bound. For unsigned > comparisons, the logically smaller value should be the lower bound. > The size of the data and the bounds can be specified as byte, word, or long. If Rn is a > data register and the operation size is byte or word, only the appropriate low-order part > of Rn is checked. If Rn is an address register and the operation size is byte or word, > the bounds operands are sign-extended to 32 bits, and the resultant operands are > compared to the full 32 bits of An. > If the upper bound equals the lower bound, the valid range is a single value. > > > signed-off-by: Guolei > incorrect Signed-off-by: format > > --- > target-m68k/translate.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 74 insertions(+) I'm fairly sure this fails scripts/checkpatch.pl but I was unable to run it as your email seems to be html with a base64 uuencoded blob in it. Please check your patch with checkpatch.pl before re-sending. Also please fix your mailer to send plain text emails or better yet use git-send-email to send the patch. -- Alex Bennée