From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53197)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1XTFiB-0005LH-US
	for qemu-devel@nongnu.org; Sun, 14 Sep 2014 15:43:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1XTFi7-0003yO-P0
	for qemu-devel@nongnu.org; Sun, 14 Sep 2014 15:43:51 -0400
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
References: <1410626734-3804-1-git-send-email-rth@twiddle.net>
	<1410626734-3804-6-git-send-email-rth@twiddle.net>
In-reply-to: <1410626734-3804-6-git-send-email-rth@twiddle.net>
Date: Sun, 14 Sep 2014 20:43:35 +0100
Message-ID: <878ulmoumw.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 05/23] target-ppc: Use cpu_exec_enter qom
	hook
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: peter.maydell@linaro.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, aliguori@amazon.com, afaerber@suse.de


Richard Henderson writes:

> Cc: qemu-ppc@nongnu.org
> Signed-off-by: Richard Henderson <rth@twiddle.net>
<snip>
> +static void ppc_cpu_exec_enter(CPUState *cs)
> +{
> +    PowerPCCPU *cpu = POWERPC_CPU(cs);
> +    CPUPPCState *env = &cpu->env;
> +

Ok the naming of those structures and the order to traverse them gets
confusing - is it really CPUState -> ${ARCH}CPU -> ${ARCH}CPUState?

Anyway...

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


> +    env->reserve_addr = -1;
> +}
> +
>  /* CPUClass::reset() */
>  static void ppc_cpu_reset(CPUState *s)
>  {
> @@ -9638,6 +9646,7 @@ static void ppc_cpu_class_init(ObjectClass *oc, void *data)
>      cc->write_elf64_qemunote = ppc64_cpu_write_elf64_qemunote;
>  #endif
>  #endif
> +    cc->cpu_exec_enter = ppc_cpu_exec_enter;
>  
>      cc->gdb_num_core_regs = 71;


-- 
Alex Bennée