From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45229)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WuIOf-0007AM-I3
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 05:31:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WuIOb-0000vI-3B
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 05:31:13 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <5396C63C.6010302@kamp.de> (Peter Lieven's message of "Tue, 10
	Jun 2014 10:47:56 +0200")
References: <1402387463-17246-1-git-send-email-pl@kamp.de>
	<20140610084535.GB10960@grmbl.mre> <5396C63C.6010302@kamp.de>
Date: Tue, 10 Jun 2014 11:30:59 +0200
Message-ID: <878up5f6wc.fsf@troll.troll>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCHv3] migration: catch unknown flags in
	ram_load
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: qemu-stable@nongnu.org, qemu-devel@nongnu.org, Amit Shah <amit.shah@redhat.com>, pbonzini@redhat.com, dgilbert@redhat.com

Peter Lieven <pl@kamp.de> wrote:
> On 10.06.2014 10:45, Amit Shah wrote:
>> On (Tue) 10 Jun 2014 [10:04:23], Peter Lieven wrote:
>>> if a saved vm has unknown flags in the memory data qemu
>>> currently simply ignores this flag and continues which
>>> yields in an unpredictable result.
>>>
>>> this patch catches all unknown flags and
>>> aborts the loading of the vm.
>>>
>>> CC: qemu-stable@nongnu.org
>>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> Reviewed-by: Amit Shah <amit.shah@redhat.com>
>>
>>> ---
>>> v2->v3: - reworked last case in the if statement
>>>          - added an error_report in case of an unknown flag [David]
>> Thanks.  Would be nice to get an error_report() for the other error
>> conditions, too.  It's not fun to learn migration has failed, w/o any
>> clue of why or where.
>
> Ok, will send v4.
>
> Peter

Thanks very much.