From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLAjI-0002d0-01 for qemu-devel@nongnu.org; Wed, 05 Mar 2014 07:15:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLAjD-0001KT-K5 for qemu-devel@nongnu.org; Wed, 05 Mar 2014 07:15:19 -0500 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:36679 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLAjD-0001KB-EV for qemu-devel@nongnu.org; Wed, 05 Mar 2014 07:15:15 -0500 References: <1393952650-16802-1-git-send-email-rth@twiddle.net> <1393952650-16802-8-git-send-email-rth@twiddle.net> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1393952650-16802-8-git-send-email-rth@twiddle.net> Date: Wed, 05 Mar 2014 12:15:36 +0000 Message-ID: <878usodeon.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 07/10] tcg-aarch64: Remove the shift_immparameter from tcg_out_cmpp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Peter Maydell , qemu-devel@nongnu.org, Claudio Fontana Richard Henderson writes: > It was unused. Let's not overcomplicate things before we need them. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/aarch64/tcg-target.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > index dca7632..2b55393 100644 > --- a/tcg/aarch64/tcg-target.c > +++ b/tcg/aarch64/tcg-target.c > @@ -541,11 +541,10 @@ static inline void tcg_out_rotl(TCGContext *s, TCGType ext, > tcg_out_extr(s, ext, rd, rn, rn, bits - (m & max)); > } > > -static inline void tcg_out_cmp(TCGContext *s, TCGType ext, TCGReg rn, > - TCGReg rm, int shift_imm) > +static void tcg_out_cmp(TCGContext *s, TCGType ext, TCGReg rn, TCGReg rm) > { > /* Using CMP alias SUBS wzr, Wn, Wm */ > - tcg_out_arith(s, ARITH_SUBS, ext, TCG_REG_XZR, rn, rm, shift_imm); > + tcg_out_arith(s, ARITH_SUBS, ext, TCG_REG_XZR, rn, rm, 0); > } > > static inline void tcg_out_cset(TCGContext *s, TCGType ext, > @@ -903,7 +902,7 @@ static void tcg_out_tlb_read(TCGContext *s, TCGReg addr_reg, > (is_read ? offsetof(CPUTLBEntry, addr_read) > : offsetof(CPUTLBEntry, addr_write))); > /* Perform the address comparison. */ > - tcg_out_cmp(s, (TARGET_LONG_BITS == 64), TCG_REG_X0, TCG_REG_X3, 0); > + tcg_out_cmp(s, (TARGET_LONG_BITS == 64), TCG_REG_X0, TCG_REG_X3); > *label_ptr = s->code_ptr; > /* If not equal, we jump to the slow path. */ > tcg_out_goto_cond_noaddr(s, TCG_COND_NE); > @@ -1242,13 +1241,13 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, > > case INDEX_op_brcond_i64: > case INDEX_op_brcond_i32: > - tcg_out_cmp(s, ext, a0, a1, 0); > + tcg_out_cmp(s, ext, a0, a1); > tcg_out_goto_label_cond(s, a2, args[3]); > break; > > case INDEX_op_setcond_i64: > case INDEX_op_setcond_i32: > - tcg_out_cmp(s, ext, a1, a2, 0); > + tcg_out_cmp(s, ext, a1, a2); > tcg_out_cset(s, 0, a0, args[3]); > break; -- Alex Bennée