From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8yHI-0003K9-LE for qemu-devel@nongnu.org; Mon, 12 Aug 2013 15:59:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8yH9-0001Sa-Nj for qemu-devel@nongnu.org; Mon, 12 Aug 2013 15:59:44 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:51393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8yH9-0001SR-JV for qemu-devel@nongnu.org; Mon, 12 Aug 2013 15:59:35 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Aug 2013 20:59:35 +0100 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id DA7DE6E803F for ; Mon, 12 Aug 2013 15:59:26 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7CJxVCk29687914 for ; Mon, 12 Aug 2013 15:59:31 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r7CJxVV3017740 for ; Mon, 12 Aug 2013 15:59:31 -0400 From: Anthony Liguori In-Reply-To: <20130812180922.GA1309@redhat.com> References: <1376316104-11269-1-git-send-email-aliguori@us.ibm.com> <20130812145436.GA31779@redhat.com> <877gfr9bqu.fsf@codemonkey.ws> <20130812180922.GA1309@redhat.com> Date: Mon, 12 Aug 2013 14:59:24 -0500 Message-ID: <878v06brz6.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v2] pc: drop external DSDT loading List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Gerd Hoffmann "Michael S. Tsirkin" writes: > On Mon, Aug 12, 2013 at 10:20:41AM -0500, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >> > On Mon, Aug 12, 2013 at 09:01:44AM -0500, Anthony Liguori wrote: >> >> This breaks migration and is unneeded with modern SeaBIOS. >> >> >> >> Signed-off-by: Anthony Liguori >> > >> > Hmm don't we want to keep it around for machine types >> > 1.4.0 and 1.5.0? >> >> Hrm, why? > > Well this modifies the contents of ROM which > is loaded from FW CFG and isn't migrated, correct? > If guest is migrated from 1.6 to 1.5 > while it is loading the ROM, > it will likely get a corrupted table. No, if you migrate from 1.6 to 1.5 the ROM is untouched. ROMs aren't migrated so it doesn't really matter. If you migrate from 1.5 while reading the ROM contents, then badness can ensue but that's already the case without this patch. Regards, Anthony Liguori > > >> Regards, >> >> Anthony Liguori >> >> > >> > By the way, copy stable as well? >> > Loading it unconditonally is a cross >> > version migration bug that we probably want to fix >> > on stable branch - disabling for 1.3.0 and older. >> > >> >> --- >> >> v1 -> v2 >> >> - Still load external DSDT for q35 >> >> --- >> >> hw/i386/pc_piix.c | 1 - >> >> 1 file changed, 1 deletion(-) >> >> >> >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >> >> index 95c45b8..311574a 100644 >> >> --- a/hw/i386/pc_piix.c >> >> +++ b/hw/i386/pc_piix.c >> >> @@ -103,7 +103,6 @@ static void pc_init1(MemoryRegion *system_memory, >> >> OBJECT(icc_bridge), NULL); >> >> >> >> pc_cpus_init(cpu_model, icc_bridge); >> >> - pc_acpi_init("acpi-dsdt.aml"); >> >> >> >> if (kvm_enabled() && kvmclock_enabled) { >> >> kvmclock_create(); >> >> -- >> >> 1.8.0