From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmdaW-00069e-QB for qemu-devel@nongnu.org; Wed, 12 Jun 2013 01:27:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmdaQ-00046l-GH for qemu-devel@nongnu.org; Wed, 12 Jun 2013 01:27:16 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:45470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmdaP-00046Q-Q9 for qemu-devel@nongnu.org; Wed, 12 Jun 2013 01:27:10 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 12 Jun 2013 10:50:30 +0530 From: "M. Mohan Kumar" In-Reply-To: <51B76A28.5030008@msgid.tls.msk.ru> References: <1370897240-23490-1-git-send-email-mjt@msgid.tls.msk.ru> <51B7183E.6070203@msgid.tls.msk.ru> <87ehc8tvd5.fsf@gmail.com> <51B76A28.5030008@msgid.tls.msk.ru> Date: Wed, 12 Jun 2013 10:56:57 +0530 Message-ID: <878v2fucf2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-trivial@nongnu.org, Peter Maydell , qemu-devel@nongnu.org Michael Tokarev writes: > 11.06.2013 21:23, M. Mohan Kumar wrote: >> Peter Maydell writes: >> >> How about this approach? > > Well, this is definitely wrong :) > >> -if test "$softmmu" = yes ; then >> - if test "$virtfs" != no ; then >> + >> +if test "$virtfs" != no ; then >> + if test "$softmmu" = yes ; then >> if test "$cap" = yes && test "$linux" = yes && test "$attr" = yes ; then >> virtfs=yes >> tools="$tools fsdev/virtfs-proxy-helper\$(EXESUF)" >> @@ -3415,6 +3416,12 @@ if test "$softmmu" = yes ; then >> fi >> virtfs=no >> fi >> + else >> + if test "$virtfs" = yes; then >> + error_exit "VirtFS is supported only on Linux and requires softmmu" >> + else >> + virtfs=no >> + fi >> fi >> if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then >> if [ "$guest_agent" = "yes" ]; then > > Now this "if [ $linux..." test is only checked > if $virtfs != no. Before, it was checked when > $softmmu != no... My bad :(, I missed check for guest_agent inside softmmu case. > > FWIW, I still don't understand what Peter Maydell dislikes > in a simplest case I posted initially, where we merely ignore > (disable) virtfs in case !softmmu. We should probably do the > same for alot of other features which makes sense only if > softmmu==yes, and omit many configure tests which are still > done even if softmmu is disabled, but that's a different > patch for sure. Maube we should separate out this last linux|bsd|solaris > test and add another if softmmu there, for readability, so that > disabling of virtfs will be closer to other virtfs tests. > > I applied my initial patch to our debian tree to fix build > failure for now, because else it fails during build. > > Thanks, > > /mjt