From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ught8-0000tp-FB for qemu-devel@nongnu.org; Sun, 26 May 2013 16:49:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ught7-0005Za-1n for qemu-devel@nongnu.org; Sun, 26 May 2013 16:49:58 -0400 Received: from mail-ob0-x22c.google.com ([2607:f8b0:4003:c01::22c]:37778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ught6-0005ZS-TB for qemu-devel@nongnu.org; Sun, 26 May 2013 16:49:56 -0400 Received: by mail-ob0-f172.google.com with SMTP id tb18so7395185obb.31 for ; Sun, 26 May 2013 13:49:55 -0700 (PDT) From: Anthony Liguori In-Reply-To: <51A26E95.5000207@redhat.com> References: <1369581694-1655-1-git-send-email-mst@redhat.com> <20130526175110.GA3115@redhat.com> <20130526181017.GB3115@redhat.com> <51A253C6.7060303@redhat.com> <20130526183747.GB3427@redhat.com> <51A25A2D.8030700@redhat.com> <20130526200251.GA4305@redhat.com> <51A26E95.5000207@redhat.com> Date: Sun, 26 May 2013 15:49:53 -0500 Message-ID: <878v314gb2.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , "Michael S. Tsirkin" Cc: Peter Maydell , Rusty Russell , qemu-devel@nongnu.org, virtualization Paolo Bonzini writes: > Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: >> > My fault. I should have looked at linux/types.h (actually asm-generic/). >> >> Not really, __uX appear in the headers that were posted. Which is a problem because this is a reserved namespace in C99. >> What I'm saying is - a chance of a conflict is very remote, >> if it happens it's a build failure so easy to debug. > > I'm sure that others will complain, :) but you can go ahead. I think we should clean up the virtio headers in the kernel first. Seems like a good thing to do given the standardization effort too. There are lots of headers in uapi that use the C99 int types so there doesn't seem to be a reason they couldn't be used in virtio. fuse.h even has a: #ifdef __KERNEL__ #include #else #include #endif Which seems like a reasonable thing to do. The only other kernel dependency is linux/if_ether.h to define ETH_ALEN. But it seems completely reasonable to define a VIRTIO_NET_MAC_ALEN or something like that. This would make the virtio headers completely stand alone and includable in userspace (without violating C99). Perhaps it's even worth moving the headers from uapi/linux to uapi/virtio. Rusty, what do you think? Regards, Anhtony Liguori > > Paolo