* [Qemu-devel] [PULL for-1.3 0/1] QMP queue
@ 2012-11-29 13:10 Luiz Capitulino
2012-11-29 13:10 ` [Qemu-devel] [PULL] qapi: fix qapi_dealloc_type_size parameter type Luiz Capitulino
2012-11-30 18:42 ` [Qemu-devel] [PULL for-1.3 0/1] QMP queue Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Luiz Capitulino @ 2012-11-29 13:10 UTC (permalink / raw)
To: qemu-devel; +Cc: aliguori
This is an important fix as it fixes a 32-bit breakage.
The changes (since e9bff10f8db94912b1b0e6e2e3394cae02faf614) are available
in the following repository:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
Bruce Rogers (1):
qapi: fix qapi_dealloc_type_size parameter type
qapi/qapi-dealloc-visitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.8.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [Qemu-devel] [PULL] qapi: fix qapi_dealloc_type_size parameter type 2012-11-29 13:10 [Qemu-devel] [PULL for-1.3 0/1] QMP queue Luiz Capitulino @ 2012-11-29 13:10 ` Luiz Capitulino 2012-11-30 18:42 ` [Qemu-devel] [PULL for-1.3 0/1] QMP queue Anthony Liguori 1 sibling, 0 replies; 3+ messages in thread From: Luiz Capitulino @ 2012-11-29 13:10 UTC (permalink / raw) To: qemu-devel; +Cc: aliguori From: Bruce Rogers <brogers@suse.com> The second parameter to qapi_dealloc_type_size should be a uint64_t *, not a size_t *. This was causing our 32 bit x86 build to fail, since warnings are treated as errors. Signed-off-by: Bruce Rogers <brogers@suse.com> Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com> Reviewed-by: Stefan Weil <sw@weilnetz.de> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> --- qapi/qapi-dealloc-visitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c index a07b171..75214e7 100644 --- a/qapi/qapi-dealloc-visitor.c +++ b/qapi/qapi-dealloc-visitor.c @@ -132,7 +132,7 @@ static void qapi_dealloc_type_number(Visitor *v, double *obj, const char *name, { } -static void qapi_dealloc_type_size(Visitor *v, size_t *obj, const char *name, +static void qapi_dealloc_type_size(Visitor *v, uint64_t *obj, const char *name, Error **errp) { } -- 1.8.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PULL for-1.3 0/1] QMP queue 2012-11-29 13:10 [Qemu-devel] [PULL for-1.3 0/1] QMP queue Luiz Capitulino 2012-11-29 13:10 ` [Qemu-devel] [PULL] qapi: fix qapi_dealloc_type_size parameter type Luiz Capitulino @ 2012-11-30 18:42 ` Anthony Liguori 1 sibling, 0 replies; 3+ messages in thread From: Anthony Liguori @ 2012-11-30 18:42 UTC (permalink / raw) To: Luiz Capitulino, qemu-devel Luiz Capitulino <lcapitulino@redhat.com> writes: > This is an important fix as it fixes a 32-bit breakage. > > The changes (since e9bff10f8db94912b1b0e6e2e3394cae02faf614) are available > in the following repository: > > git://repo.or.cz/qemu/qmp-unstable.git queue/qmp > > Bruce Rogers (1): > qapi: fix qapi_dealloc_type_size parameter type > > qapi/qapi-dealloc-visitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Pulled. Thanks. Regards, Anthony Liguori > > -- > 1.8.0 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-30 18:43 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-11-29 13:10 [Qemu-devel] [PULL for-1.3 0/1] QMP queue Luiz Capitulino 2012-11-29 13:10 ` [Qemu-devel] [PULL] qapi: fix qapi_dealloc_type_size parameter type Luiz Capitulino 2012-11-30 18:42 ` [Qemu-devel] [PULL for-1.3 0/1] QMP queue Anthony Liguori
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).