From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEg7M-000670-R9 for qemu-devel@nongnu.org; Thu, 20 Sep 2012 08:44:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEg7H-0001Mb-2e for qemu-devel@nongnu.org; Thu, 20 Sep 2012 08:44:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEg7G-0001MX-R5 for qemu-devel@nongnu.org; Thu, 20 Sep 2012 08:44:27 -0400 From: Markus Armbruster References: <1347562697-15411-1-git-send-email-owasserm@redhat.com> <1347562697-15411-3-git-send-email-owasserm@redhat.com> Date: Thu, 20 Sep 2012 14:44:23 +0200 In-Reply-To: <1347562697-15411-3-git-send-email-owasserm@redhat.com> (Orit Wasserman's message of "Thu, 13 Sep 2012 21:58:16 +0300") Message-ID: <878vc43lug.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 2/3] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: kwolf@redhat.com, aliguori@us.ibm.com, akong@redhat.com, mst@redhat.com, quintela@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com Orit Wasserman writes: > No need to add non blocking parameters to the blocking inet_connect > add block parameter for inet_connect_opts instead of using QemuOpt "block". I believe option "block" in qemu-sockets.c's dummy_opts is now unused, and should be dropped. It was added in commit a6ba35b3.