qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Lukas Straub <lukasstraub2@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>,  Peter Xu <peterx@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	 Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 12/13] ram compress: Assert that the file buffer matches the result
Date: Fri, 28 Apr 2023 19:24:48 +0200	[thread overview]
Message-ID: <87a5yrapi7.fsf@secure.mitica> (raw)
In-Reply-To: <a21bc7fdd9b2cd6ab99cdd7ae3390713085bf1a0.1681983401.git.lukasstraub2@web.de> (Lukas Straub's message of "Thu, 20 Apr 2023 11:48:31 +0200")

Lukas Straub <lukasstraub2@web.de> wrote:
> Before this series, "nothing to send" was handled by the file buffer
> being empty. Now it is tracked via param->result.
>
> Assert that the file buffer state matches the result.
>
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Even when:

> +/*
> + * Check if the writable buffer is empty
> + */
> +
> +bool qemu_file_buffer_empty(QEMUFile *file)
> +{
> +    assert(qemu_file_is_writable(file));

A function that is basically an assert

> +    assert(qemu_file_buffer_empty(f));

Is always called as an assert O:-)



  reply	other threads:[~2023-04-28 17:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20  9:47 [PATCH v2 00/13] migration/ram.c: Refactor compress code Lukas Straub
2023-04-20  9:47 ` [PATCH v2 01/13] qtest/migration-test.c: Add postcopy tests with compress enabled Lukas Straub
2023-04-20 10:20   ` Juan Quintela
2023-04-20 10:37     ` Lukas Straub
2023-04-20 21:12       ` Juan Quintela
2023-04-20  9:47 ` [PATCH v2 02/13] ram.c: Let the compress threads return a CompressResult enum Lukas Straub
2023-04-20 21:13   ` Juan Quintela
2023-04-20  9:47 ` [PATCH v2 03/13] ram.c: Dont change param->block in the compress thread Lukas Straub
2023-04-20 21:13   ` Juan Quintela
2023-04-20  9:48 ` [PATCH v2 04/13] ram.c: Reset result after sending queued data Lukas Straub
2023-04-28 11:59   ` Juan Quintela
2023-04-20  9:48 ` [PATCH v2 05/13] ram.c: Do not call save_page_header() from compress threads Lukas Straub
2023-04-28 12:02   ` Juan Quintela
2023-04-20  9:48 ` [PATCH v2 06/13] ram.c: Call update_compress_thread_counts from compress_send_queued_data Lukas Straub
2023-04-28 12:10   ` Juan Quintela
2023-04-20  9:48 ` [PATCH v2 07/13] ram.c: Remove last ram.c dependency from the core compress code Lukas Straub
2023-04-28 12:14   ` Juan Quintela
2023-04-20  9:48 ` [PATCH v2 08/13] ram.c: Introduce whitespace (squash with next patch) Lukas Straub
2023-04-28 16:13   ` Juan Quintela
2023-04-20  9:48 ` [PATCH v2 09/13] ram.c: Move core compression code into its own file Lukas Straub
2023-04-20  9:48 ` [PATCH v2 10/13] ram.c: Remove whitespace (squash with previous patch) Lukas Straub
2023-04-28 16:15   ` Juan Quintela
2023-04-20  9:48 ` [PATCH v2 11/13] ram.c: Move core decompression code into its own file Lukas Straub
2023-04-28 17:22   ` Juan Quintela
2023-04-20  9:48 ` [PATCH v2 12/13] ram compress: Assert that the file buffer matches the result Lukas Straub
2023-04-28 17:24   ` Juan Quintela [this message]
2023-04-20  9:48 ` [PATCH v2 13/13] ram-compress.c: Make target independent Lukas Straub
2023-04-28 17:29   ` Juan Quintela
2023-04-20  9:59 ` [PATCH v2 14/13] migration: Initialize and cleanup decompression in migration.c Lukas Straub
2023-04-28 17:33   ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5yrapi7.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=lukasstraub2@web.de \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).