From: Fabiano Rosas <farosas@suse.de>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Alexander Graf" <agraf@csgraf.de>,
"Cornelia Huck" <cohuck@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>
Subject: Re: [PATCH v11 06/13] tests/qtest: Adjust and document query-cpu-model-expansion test for arm
Date: Thu, 27 Apr 2023 10:16:48 -0300 [thread overview]
Message-ID: <87a5ytpirj.fsf@suse.de> (raw)
In-Reply-To: <c2853e95-2aec-246a-5846-d91d40329c61@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> On 4/26/23 19:00, Fabiano Rosas wrote:
>> We're about to move the 32-bit CPUs under CONFIG_TCG, so adjust the
>> query-cpu-model-expansion test to check against the cortex-a7, which
>> is already under CONFIG_TCG. That allows the next patch to contain
>> only code movement.
>>
>> While here add comments clarifying what we're testing.
>>
>> Signed-off-by: Fabiano Rosas<farosas@suse.de>
>> Suggested-by: Philippe Mathieu-Daudé<philmd@linaro.org>
>> ---
>> tests/qtest/arm-cpu-features.c | 20 +++++++++++++++++---
>> 1 file changed, 17 insertions(+), 3 deletions(-)
>
> I don't see why you're changing the cpu model here.
> Neither cpu will work, of course, but why change?
>
Because there's already a patch in master that puts the cortex-a7 under
CONFIG_TCG, so I can have the whole if/else in this patch.
If I keep the cortex-a15, this change needs to go into the next patch
("move cpu_tcg to tcg/cpu32.c") which moves the rest of the 32bit cpus,
which was supposed to be only code movement.
next prev parent reply other threads:[~2023-04-27 13:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 18:00 [PATCH v11 00/13] target/arm: Allow CONFIG_TCG=n builds Fabiano Rosas
2023-04-26 18:00 ` [PATCH v11 01/13] target/arm: Move cortex sysregs into a separate file Fabiano Rosas
2023-04-28 22:41 ` Philippe Mathieu-Daudé
2023-04-26 18:00 ` [PATCH v11 02/13] target/arm: Remove dead code from cpu_max_set_sve_max_vq Fabiano Rosas
2023-04-26 18:00 ` [PATCH v11 03/13] target/arm: Extract TCG -cpu max code into a function Fabiano Rosas
2023-04-26 18:00 ` [PATCH v11 04/13] target/arm: Do not expose all -cpu max features to qtests Fabiano Rosas
2023-04-27 9:37 ` Richard Henderson
2023-04-28 22:35 ` Philippe Mathieu-Daudé
2023-05-02 12:23 ` Fabiano Rosas
2023-04-26 18:00 ` [PATCH v11 05/13] target/arm: Move 64-bit TCG CPUs into tcg/ Fabiano Rosas
2023-04-28 22:38 ` Philippe Mathieu-Daudé
2023-04-26 18:00 ` [PATCH v11 06/13] tests/qtest: Adjust and document query-cpu-model-expansion test for arm Fabiano Rosas
2023-04-27 8:08 ` Thomas Huth
2023-04-27 9:39 ` Richard Henderson
2023-04-27 13:16 ` Fabiano Rosas [this message]
2023-04-28 7:45 ` Richard Henderson
2023-04-28 13:43 ` Fabiano Rosas
2023-05-02 9:46 ` Peter Maydell
2023-04-26 18:00 ` [PATCH v11 07/13] target/arm: move cpu_tcg to tcg/cpu32.c Fabiano Rosas
2023-04-28 22:37 ` Philippe Mathieu-Daudé
2023-04-26 18:00 ` [PATCH v11 08/13] tests/qtest: Fix tests when no KVM or TCG are present Fabiano Rosas
2023-04-27 9:42 ` Richard Henderson
2023-04-27 18:41 ` Michael S. Tsirkin
2023-04-28 22:32 ` Philippe Mathieu-Daudé
2023-04-26 18:00 ` [PATCH v11 09/13] tests/avocado: Pass parameters to migration test Fabiano Rosas
2023-04-26 18:00 ` [PATCH v11 10/13] arm/Kconfig: Always select SEMIHOSTING when TCG is present Fabiano Rosas
2023-04-26 18:00 ` [PATCH v11 11/13] arm/Kconfig: Do not build TCG-only boards on a KVM-only build Fabiano Rosas
2023-04-26 18:00 ` [PATCH v11 12/13] tests/qtest: Restrict tpm-tis-i2c-test to CONFIG_TCG Fabiano Rosas
2023-04-27 7:00 ` Thomas Huth
2023-04-27 9:44 ` Richard Henderson
2023-04-26 18:00 ` [PATCH v11 13/13] gitlab-ci: Check building KVM-only aarch64 target Fabiano Rosas
2023-04-27 9:46 ` Richard Henderson
2023-05-02 9:55 ` [PATCH v11 00/13] target/arm: Allow CONFIG_TCG=n builds Peter Maydell
2023-05-02 14:51 ` Peter Maydell
2023-05-02 16:07 ` Peter Maydell
2023-05-02 16:23 ` Fabiano Rosas
2023-05-02 17:11 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ytpirj.fsf@suse.de \
--to=farosas@suse.de \
--cc=agraf@csgraf.de \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).