From: "Alex Bennée" <alex.bennee@linaro.org>
To: TYZPR06MB5418216269D0ED2EB37D6FF49DBE9@TYZPR06MB5418.apcprd06.prod.outlook.com
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Yohei Kojima" <y-koj@outlook.jp>,
qemu-devel@nongnu.org
Subject: Re: [RFC PATCH v2 2/2] linux-user: replace strerror() function to the thread safe qemu_strerror()
Date: Thu, 30 Mar 2023 15:08:59 +0100 [thread overview]
Message-ID: <87a5zunxep.fsf@linaro.org> (raw)
In-Reply-To: <TYZPR06MB541876821E3AD1306D6DC88A9DBE9@TYZPR06MB5418.apcprd06.prod.outlook.com>
Yohei Kojima <y-koj@outlook.jp> writes:
> strerror() is not guaranteed to be thread-safe as described in
> (https://gitlab.com/qemu-project/qemu/-/issues/416).
>
> This commit changes files under /linux-user that call strerror() to call
> the safer qemu_strerror().
As mentioned on bug tracker I think you need some more patches for the
other uses. But for this one:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-03-30 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1678770219.git.y-koj@outlook.jp>
2023-03-14 6:40 ` [RFC PATCH v2 1/2] util: Add thread-safe qemu_strerror() function Yohei Kojima
2023-03-14 6:51 ` Yohei Kojima
2023-03-30 14:04 ` Alex Bennée
2023-03-30 14:06 ` Alex Bennée
2023-03-14 6:40 ` [RFC PATCH v2 2/2] linux-user: replace strerror() function to the thread safe qemu_strerror() Yohei Kojima
2023-03-30 14:08 ` Alex Bennée [this message]
2023-03-30 16:04 ` Yohei Kojima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5zunxep.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=TYZPR06MB5418216269D0ED2EB37D6FF49DBE9@TYZPR06MB5418.apcprd06.prod.outlook.com \
--cc=berrange@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=y-koj@outlook.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).