qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Brian Cain <bcain@quicinc.com>
Cc: "Matheus Bernardino (QUIC)" <quic_mathbern@quicinc.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"f4bug@amsat.org" <f4bug@amsat.org>,
	"peter.maydell@linaro.org" <peter.maydell@linaro.org>
Subject: Re: [RFC PATCH v2] gdbstub: only send stop-reply packets when allowed to
Date: Fri, 16 Sep 2022 14:25:56 +0100	[thread overview]
Message-ID: <87a66z8n7g.fsf@linaro.org> (raw)
In-Reply-To: <SN6PR02MB4205789F605DBB66A4A6E178B8489@SN6PR02MB4205.namprd02.prod.outlook.com>


Brian Cain <bcain@quicinc.com> writes:

>> -----Original Message-----
>> From: Qemu-devel <qemu-devel-bounces+bcain=quicinc.com@nongnu.org>
>> On Behalf Of Matheus Tavares Bernardino
> ...
>> On Wed, 24 Aug 2022 at 14:51, Matheus Tavares Bernardino
>> <quic_mathbern@quicinc.com> wrote:
>> >
>> > Instead, let's change gdb_set_stop_cpu() to send stop messages only as a
>> > response to a previous GDB command, also making sure to check that the
>> > command accepts such a reply.
>> >
>> > Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
>> > ---
>> 
>> Gentle ping :)
>
> Alex, Peter - any thoughts on this change?

Sorry I was super busy on the run up to KVM forum, I have given some
thoughts today.

-- 
Alex Bennée


  reply	other threads:[~2022-09-16 13:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 13:39 [PATCH] gdbstub: only send stop-reply upon request Matheus Tavares Bernardino
2022-08-23 15:37 ` Matheus Tavares Bernardino
2022-08-23 15:56 ` Peter Maydell
2022-08-24 17:51 ` [RFC PATCH v2] gdbstub: only send stop-reply packets when allowed to Matheus Tavares Bernardino
2022-08-31 13:54   ` Matheus Tavares Bernardino
2022-09-16  0:59     ` Brian Cain
2022-09-16 13:25       ` Alex Bennée [this message]
2022-09-16 10:33   ` Alex Bennée
2022-09-20 11:55     ` Matheus Bernardino (QUIC)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a66z8n7g.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=bcain@quicinc.com \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quic_mathbern@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).