From: Markus Armbruster <armbru@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: fam@euphon.net, berrange@redhat.com, stefanha@redhat.com,
crosa@redhat.com, qemu-devel@nongnu.org, robhenry@microsoft.com,
aaron@os.amperecomputing.com, mahmoudabdalghany@outlook.com,
minyihh@uci.edu, cota@braap.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Luke.Craig@ll.mit.edu, pbonzini@redhat.com,
kuhn.chenqun@huawei.com, ma.mandourr@gmail.com,
aurelien@aurel32.net, f4bug@amsat.org
Subject: Re: [PATCH v1 06/15] monitor: expose monitor_puts to rest of code
Date: Thu, 21 Apr 2022 16:45:46 +0200 [thread overview]
Message-ID: <87a6ceqyud.fsf@pond.sub.org> (raw)
In-Reply-To: <20220408164742.2844631-7-alex.bennee@linaro.org> ("Alex Bennée"'s message of "Fri, 8 Apr 2022 17:47:33 +0100")
Alex Bennée <alex.bennee@linaro.org> writes:
> This helps us construct strings elsewhere before echoing to the
> monitor. It avoids having to jump through hoops like:
>
> monitor_printf(mon, "%s", s->str);
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
There's just one caller other than monitor_vprintf(). Even if you add a
few more, I'm not sure keeping it in the interface is worthwhile.
If we conclude it is, then this patch should come with a conversion of
existing uses of monitor_printf(MON, "%s", STR) to monitor_puts(MON,
STR).
If we conclude it isn't, switch the lone caller to monitor_printf() and
make monitor_puts() static in monitor.c.
next prev parent reply other threads:[~2022-04-21 14:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 16:47 [PATCH v1 00/15] testing, docs, tracepoints and cputlb hacks Alex Bennée
2022-04-08 16:47 ` [PATCH v1 01/15] tests/avocado: update aarch64_virt test to exercise -cpu max Alex Bennée
2022-04-08 16:47 ` [PATCH v1 02/15] docs/devel: add some notes on the binfmt-image-debian targets Alex Bennée
2022-04-08 16:47 ` [PATCH v1 03/15] docs/devel: drop :hidden: and :includehidden: tags Alex Bennée
2022-04-08 16:47 ` [PATCH v1 04/15] accel/tcg: move trace events to correct location Alex Bennée
2022-04-09 15:54 ` Richard Henderson
2022-04-08 16:47 ` [PATCH v1 05/15] accel/tcg: add tb_invalidate_phy_pages_fast tracepoint Alex Bennée
2022-04-09 15:57 ` Richard Henderson
2022-04-08 16:47 ` [PATCH v1 06/15] monitor: expose monitor_puts to rest of code Alex Bennée
2022-04-09 15:58 ` Richard Henderson
2022-04-21 14:45 ` Markus Armbruster [this message]
2022-04-08 16:47 ` [PATCH v1 07/15] disas: generalise plugin_printf and use for monitor_disas Alex Bennée
2022-04-09 16:04 ` Richard Henderson
2022-04-08 16:47 ` [PATCH v1 08/15] disas: use result of ->read_memory_func Alex Bennée
2022-04-09 16:07 ` Richard Henderson
2022-04-08 16:47 ` [PATCH v1 09/15] cputlb: add tracepoints for the protect/unprotect helpers Alex Bennée
2022-04-09 16:09 ` Richard Henderson
2022-04-08 16:47 ` [PATCH v1 10/15] cputlb: add tracepoints for TB invalidation Alex Bennée
2022-04-09 16:10 ` Richard Henderson
2022-04-08 16:47 ` [PATCH v1 11/15] accel/tcg: add tb_invalidate_phys_page_range tracepoint Alex Bennée
2022-04-09 16:14 ` Richard Henderson
2022-04-08 16:47 ` [PATCH v1 12/15] tests/tcg: add memory-sve test for aarch64 Alex Bennée
2022-04-08 16:47 ` [PATCH v1 13/15] plugins: extend execlog to filter matches Alex Bennée
2022-04-08 16:47 ` [PATCH v1 14/15] plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr Alex Bennée
2022-04-08 16:47 ` [PATCH v1 15/15] accel/tcg: add heuristic to invalidate al TBs in a page [hack!] Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6ceqyud.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=Luke.Craig@ll.mit.edu \
--cc=aaron@os.amperecomputing.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=crosa@redhat.com \
--cc=dgilbert@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=kuhn.chenqun@huawei.com \
--cc=ma.mandourr@gmail.com \
--cc=mahmoudabdalghany@outlook.com \
--cc=minyihh@uci.edu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=robhenry@microsoft.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).