* [PATCH] hw: m68k: Add virt compat machine type for 7.0
@ 2021-12-18 11:43 Laurent Vivier
2021-12-20 6:45 ` Thomas Huth
2021-12-20 8:17 ` Cornelia Huck
0 siblings, 2 replies; 5+ messages in thread
From: Laurent Vivier @ 2021-12-18 11:43 UTC (permalink / raw)
To: qemu-devel; +Cc: Thomas Huth, Cornelia Huck, Laurent Vivier, Juan Quintela
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
Based-On: <20211217143948.289995-1-cohuck@redhat.com>
hw/m68k/virt.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/m68k/virt.c b/hw/m68k/virt.c
index 0efa4a45c7f4..78e926a55457 100644
--- a/hw/m68k/virt.c
+++ b/hw/m68k/virt.c
@@ -304,10 +304,17 @@ type_init(virt_machine_register_types)
} \
type_init(machvirt_machine_##major##_##minor##_init);
+static void virt_machine_7_0_options(MachineClass *mc)
+{
+}
+DEFINE_VIRT_MACHINE(7, 0, true)
+
static void virt_machine_6_2_options(MachineClass *mc)
{
+ virt_machine_7_0_options(mc);
+ compat_props_add(mc->compat_props, hw_compat_6_2, hw_compat_6_2_len);
}
-DEFINE_VIRT_MACHINE(6, 2, true)
+DEFINE_VIRT_MACHINE(6, 2, false)
static void virt_machine_6_1_options(MachineClass *mc)
{
--
2.33.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] hw: m68k: Add virt compat machine type for 7.0
2021-12-18 11:43 [PATCH] hw: m68k: Add virt compat machine type for 7.0 Laurent Vivier
@ 2021-12-20 6:45 ` Thomas Huth
2021-12-20 8:17 ` Cornelia Huck
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2021-12-20 6:45 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: Cornelia Huck, Juan Quintela
On 18/12/2021 12.43, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> Based-On: <20211217143948.289995-1-cohuck@redhat.com>
>
> hw/m68k/virt.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/hw/m68k/virt.c b/hw/m68k/virt.c
> index 0efa4a45c7f4..78e926a55457 100644
> --- a/hw/m68k/virt.c
> +++ b/hw/m68k/virt.c
> @@ -304,10 +304,17 @@ type_init(virt_machine_register_types)
> } \
> type_init(machvirt_machine_##major##_##minor##_init);
>
> +static void virt_machine_7_0_options(MachineClass *mc)
> +{
> +}
> +DEFINE_VIRT_MACHINE(7, 0, true)
> +
> static void virt_machine_6_2_options(MachineClass *mc)
> {
> + virt_machine_7_0_options(mc);
> + compat_props_add(mc->compat_props, hw_compat_6_2, hw_compat_6_2_len);
> }
> -DEFINE_VIRT_MACHINE(6, 2, true)
> +DEFINE_VIRT_MACHINE(6, 2, false)
>
> static void virt_machine_6_1_options(MachineClass *mc)
> {
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hw: m68k: Add virt compat machine type for 7.0
2021-12-18 11:43 [PATCH] hw: m68k: Add virt compat machine type for 7.0 Laurent Vivier
2021-12-20 6:45 ` Thomas Huth
@ 2021-12-20 8:17 ` Cornelia Huck
2021-12-20 11:10 ` Laurent Vivier
1 sibling, 1 reply; 5+ messages in thread
From: Cornelia Huck @ 2021-12-20 8:17 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: Thomas Huth, Laurent Vivier, Juan Quintela
On Sat, Dec 18 2021, Laurent Vivier <laurent@vivier.eu> wrote:
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> Based-On: <20211217143948.289995-1-cohuck@redhat.com>
>
> hw/m68k/virt.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
Oh, I didn't realize we do it for m68k as well.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw: m68k: Add virt compat machine type for 7.0
2021-12-20 8:17 ` Cornelia Huck
@ 2021-12-20 11:10 ` Laurent Vivier
2021-12-20 11:16 ` Cornelia Huck
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Vivier @ 2021-12-20 11:10 UTC (permalink / raw)
To: Cornelia Huck, qemu-devel; +Cc: Thomas Huth, Juan Quintela
Le 20/12/2021 à 09:17, Cornelia Huck a écrit :
> On Sat, Dec 18 2021, Laurent Vivier <laurent@vivier.eu> wrote:
>
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>> ---
>> Based-On: <20211217143948.289995-1-cohuck@redhat.com>
>>
>> hw/m68k/virt.c | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> Oh, I didn't realize we do it for m68k as well.
virt-m68k is only a toy and is only used by debian for their m68k buildd.
So there is no problem if you don't manage the update, I will.
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>
Thanks,
Laurent
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw: m68k: Add virt compat machine type for 7.0
2021-12-20 11:10 ` Laurent Vivier
@ 2021-12-20 11:16 ` Cornelia Huck
0 siblings, 0 replies; 5+ messages in thread
From: Cornelia Huck @ 2021-12-20 11:16 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: Thomas Huth, Juan Quintela
On Mon, Dec 20 2021, Laurent Vivier <laurent@vivier.eu> wrote:
> Le 20/12/2021 à 09:17, Cornelia Huck a écrit :
>> On Sat, Dec 18 2021, Laurent Vivier <laurent@vivier.eu> wrote:
>>
>>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>>> ---
>>> Based-On: <20211217143948.289995-1-cohuck@redhat.com>
>>>
>>> hw/m68k/virt.c | 9 ++++++++-
>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> Oh, I didn't realize we do it for m68k as well.
>
> virt-m68k is only a toy and is only used by debian for their m68k buildd.
>
> So there is no problem if you don't manage the update, I will.
Ok, let's just keep it as a separate patch for this round, and I'll try
to remember to add it when I'm sending machine type patches in the
future.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-20 18:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-18 11:43 [PATCH] hw: m68k: Add virt compat machine type for 7.0 Laurent Vivier
2021-12-20 6:45 ` Thomas Huth
2021-12-20 8:17 ` Cornelia Huck
2021-12-20 11:10 ` Laurent Vivier
2021-12-20 11:16 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).