From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 697E8C433F5 for ; Thu, 25 Nov 2021 07:31:15 +0000 (UTC) Received: from localhost ([::1]:39912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mq9Du-0004tN-Cq for qemu-devel@archiver.kernel.org; Thu, 25 Nov 2021 02:31:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mq9BW-0004AQ-6S for qemu-devel@nongnu.org; Thu, 25 Nov 2021 02:28:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:36773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mq9BU-0007cq-RU for qemu-devel@nongnu.org; Thu, 25 Nov 2021 02:28:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637825324; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=udhOkKnj+2LEnjcvkIw7NxUWQx+TGZ1aAy6dLKljFzA=; b=WkjRvox6sbDsFPqg3sCJ43iT57Geh1HlCFctk3dHsdxz/nD5SDWgIOVeuDH6E0nL2l2zUa WElGZUwH+pEPtUqOG2Du8vM5FiNPMGOHY+ILAWre6PX6cQGD31sp5DVTIu6/PRK9xCbf2p knmZ60JRMwW9ghtnrFvzqelNOyYEQMM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-569-AAH8xmSnPWSAvL2LNsClzA-1; Thu, 25 Nov 2021 02:28:42 -0500 X-MC-Unique: AAH8xmSnPWSAvL2LNsClzA-1 Received: by mail-wm1-f70.google.com with SMTP id z138-20020a1c7e90000000b003319c5f9164so4439964wmc.7 for ; Wed, 24 Nov 2021 23:28:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version; bh=udhOkKnj+2LEnjcvkIw7NxUWQx+TGZ1aAy6dLKljFzA=; b=0dGhIkxlmvaQzxuKpfFyZUFPA/DroHKIhjJv8+k7Eqp9UJSqI53KDD6WsP1RIPGZL1 n0HxxfWmtoL2dvk9DtqW2oDxGvMN3tnawyNv535rm8h6y1k/sfcOvWt0lmC6vyw/hcCC LogL3ClGJvejJov0pHvjNWbOcbjrrWwXseOaxeWoTL4udfHL414zS2iVVuk1R6NDkQ63 Jq/B2qUqtGUcWDyuuPUu4zW00px82yQew317c8wptENJApkjOoyjFr/MELmqrFwHEAdH 37YqR4NQMMBo1ReTaWRBFHy8T9A6ZedCou244Gc/JrDlqCrIC0kr/nd2a8MpQ4PDog28 Zkog== X-Gm-Message-State: AOAM531Sg08EyROwE7pNrfQXofgr5D45LajWzQDh2nRq91sF1ALpw0h1 4FOdG706Od2q3wSj142fpz9llNczlsIVs6yQBIsCdlIo0Dmnt7KMhKexd5vmH/nJcyBmKf617sz BOljCBjmNwwsqcgk= X-Received: by 2002:adf:e512:: with SMTP id j18mr4333380wrm.532.1637825321714; Wed, 24 Nov 2021 23:28:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJxf1Z0lkSzbs0maa4LW+FHGPGat2IqI5BIeJT5Vk4e8wN06YcPcVqf/omO+XgqxqMPUbts/1Q== X-Received: by 2002:adf:e512:: with SMTP id j18mr4333363wrm.532.1637825321521; Wed, 24 Nov 2021 23:28:41 -0800 (PST) Received: from localhost (static-233-86-86-188.ipcom.comunitel.net. [188.86.86.233]) by smtp.gmail.com with ESMTPSA id z6sm2802102wmp.9.2021.11.24.23.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 23:28:41 -0800 (PST) From: Juan Quintela To: "Dr. David Alan Gilbert" Subject: Re: [PATCH v3 03/23] multifd: Rename used field to num In-Reply-To: (David Alan Gilbert's message of "Wed, 24 Nov 2021 19:37:39 +0000") References: <20211124100617.19786-1-quintela@redhat.com> <20211124100617.19786-4-quintela@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Date: Thu, 25 Nov 2021 08:28:40 +0100 Message-ID: <87a6hsg0d3.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.129.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Leonardo Bras , qemu-devel@nongnu.org, Peter Xu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" "Dr. David Alan Gilbert" wrote: > * Juan Quintela (quintela@redhat.com) wrote: >> We will need to split it later in zero_num (number of zero pages) and >> normal_num (number of normal pages). This name is better. >> >> Signed-off-by: Juan Quintela >> --- >> migration/multifd.h | 2 +- >> migration/multifd.c | 38 +++++++++++++++++++------------------- >> 2 files changed, 20 insertions(+), 20 deletions(-) >> >> diff --git a/migration/multifd.h b/migration/multifd.h >> index 15c50ca0b2..86820dd028 100644 >> --- a/migration/multifd.h >> +++ b/migration/multifd.h >> @@ -55,7 +55,7 @@ typedef struct { >> >> typedef struct { >> /* number of used pages */ >> - uint32_t used; >> + uint32_t num; > > What does 'used' actually mean here? We allocate 128 pages for each "packet". But we can ben handled less than that (we are at the end of one iteration, the end of a ramblock, ...). That is what used mean. But later on the series, we enter with normal pages, and zero pages, and naming get really confusing. So, I moved to use *_num for everything. Even after all the series, I didn't rename everything on multifd, only the fields that I have to use sooner or later. Later, Juan.