From: Juan Quintela <quintela@redhat.com>
To: "Rao, Lei" <lei.rao@intel.com>
Cc: qemu-devel@nongnu.org, chen.zhang@intel.com,
zhang.zhanghailiang@huawei.com, dgilbert@redhat.com
Subject: Re: [PATCH 2/2] migration/ram.c: Remove the qemu_mutex_lock in colo_flush_ram_cache.
Date: Wed, 10 Nov 2021 10:56:17 +0100 [thread overview]
Message-ID: <87a6ic2v26.fsf@secure.mitica> (raw)
In-Reply-To: <1636533456-5374-2-git-send-email-lei.rao@intel.com> (Lei Rao's message of "Wed, 10 Nov 2021 16:37:36 +0800")
"Rao, Lei" <lei.rao@intel.com> wrote:
> From: "Rao, Lei" <lei.rao@intel.com>
>
> The code to acquire bitmap_mutex is added in the commit of
> "63268c4970a5f126cc9af75f3ccb8057abef5ec0". There is no
> need to acquire bitmap_mutex in colo_flush_ram_cache(). This
> is because the colo_flush_ram_cache only be called on the COLO
> secondary VM, which is the destination side.
> On the COLO secondary VM, only the COLO thread will touch
> the bitmap of ram cache.
>
> Signed-off-by: Lei Rao <lei.rao@intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
As we are on the softfreeze, I am queuing this on my next-7.0 branch.
Later, Juan.
next prev parent reply other threads:[~2021-11-10 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 8:37 [PATCH 1/2] Fixed a QEMU hang when guest poweroff in COLO mode Rao, Lei
2021-11-10 8:37 ` [PATCH 2/2] migration/ram.c: Remove the qemu_mutex_lock in colo_flush_ram_cache Rao, Lei
2021-11-10 9:56 ` Juan Quintela [this message]
2021-11-11 2:24 ` Zhang, Chen
2021-11-10 9:55 ` [PATCH 1/2] Fixed a QEMU hang when guest poweroff in COLO mode Juan Quintela
2021-11-10 12:53 ` Rao, Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6ic2v26.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=lei.rao@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).