From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B768C4743C for ; Mon, 14 Jun 2021 16:44:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B27F6108E for ; Mon, 14 Jun 2021 16:44:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B27F6108E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsph0-0005qE-HP for qemu-devel@archiver.kernel.org; Mon, 14 Jun 2021 12:44:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lspg8-00053X-1d for qemu-devel@nongnu.org; Mon, 14 Jun 2021 12:43:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47843) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lspg4-0006SA-Ch for qemu-devel@nongnu.org; Mon, 14 Jun 2021 12:43:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623688984; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lqqzIIAEg1D4TrMNWDJvMwilYF7tGHqzgnEVr+KhyAM=; b=KET+P0x4igVt7wh9xBgakWBzd1sHI98RYXw+GP27lhVeRW8T12QjoPhhKoV0p3OzUa25Bv UFajFMyFsYNmP3VKAdnGw/mg46AJsp7aZdpTXBNuf4plQz3LZ72okQR4MfTvHejVMyhLRc LcZZ4S2mcwvAA58gDwno+eoxv8e/SY4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-393-Uy2cepSdMHuGVN-FUtSDFg-1; Mon, 14 Jun 2021 12:43:03 -0400 X-MC-Unique: Uy2cepSdMHuGVN-FUtSDFg-1 Received: by mail-wr1-f72.google.com with SMTP id m27-20020a056000025bb0290114d19822edso7276491wrz.21 for ; Mon, 14 Jun 2021 09:43:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version :content-transfer-encoding; bh=lqqzIIAEg1D4TrMNWDJvMwilYF7tGHqzgnEVr+KhyAM=; b=MPDpUXfd2luoIj8OyzDyhXCB4JbgGN53Dkoz6IZJGZLjvq2Uep9EbBN5cj0huv3TaE GyotPpjF3J3hLinAs5Lt0yiFGx667MLkX9zs5HUzgksAGcMMkrlRzXJBINiXwcTHTxMw HL/J/ahKDQDkHHadsw0mAeikadsWSfjza9k/rF0U5E2Lm1IA+Pgnl95GM/581usOyg3Z BoVizb3iiaVKj3j82fnQEU5c9BOhYZryPKqbftgUpOkJY4c5fMMZ7p+77vQScEj3upXK BeoGuTh9wNVPM2jl1NFD2vb2vLIpxm1JOLUuHNJRDZV9R3vi2Tl0ApGDbnYMVJGhBh2f XctA== X-Gm-Message-State: AOAM530k6pAwuRQE+eccxbstn5IsNJ0tacd1NzIryjr0d/FpcSeu0Uf8 /T1VNyyvX80wXYTiUrygSrSLxQdwmOC+4oqPwbzZX/z/xWWA587ektz5E+n5wutbty0xCXZkI6D slEWiJkUQwuH0gM0= X-Received: by 2002:a5d:4744:: with SMTP id o4mr13662157wrs.354.1623688982315; Mon, 14 Jun 2021 09:43:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZgBFsj8TSgyQ+o/vpeetQ44fWb1ZKyfqkrQHrWmtXfVA8qr3mxvgqVmH5DWY8YxACld7Y1Q== X-Received: by 2002:a5d:4744:: with SMTP id o4mr13662129wrs.354.1623688982158; Mon, 14 Jun 2021 09:43:02 -0700 (PDT) Received: from localhost (62.83.194.64.dyn.user.ono.com. [62.83.194.64]) by smtp.gmail.com with ESMTPSA id r6sm16440384wrz.91.2021.06.14.09.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 09:43:01 -0700 (PDT) From: Juan Quintela To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Subject: Re: [PATCH 3/7] net/rocker: use GDateTime for formatting timestamp in debug messages In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Fri, 11 Jun 2021 17:28:35 +0100") References: <20210505103702.521457-1-berrange@redhat.com> <20210505103702.521457-4-berrange@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Mon, 14 Jun 2021 18:43:00 +0200 Message-ID: <87a6nsgzxn.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Kevin Wolf , Jiri Pirko , qemu-block@nongnu.org, Markus Armbruster , Jason Wang , qemu-devel@nongnu.org, Laurent Vivier , virtio-fs@redhat.com, Gerd Hoffmann , Stefan Hajnoczi , Max Reitz , "Dr. David Alan Gilbert" , Brad Smith Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Daniel P. Berrang=C3=A9 wrote: > ping: anyone willing to give a review of this one > > On Wed, May 05, 2021 at 11:36:58AM +0100, Daniel P. Berrang=C3=A9 wrote: >> The GDateTime APIs provided by GLib avoid portability pitfalls, such >> as some platforms where 'struct timeval.tv_sec' field is still 'long' >> instead of 'time_t'. When combined with automatic cleanup, GDateTime >> often results in simpler code too. >>=20 >> Signed-off-by: Daniel P. Berrang=C3=A9 >> --- >> hw/net/rocker/rocker.h | 11 +++-------- >> 1 file changed, 3 insertions(+), 8 deletions(-) >>=20 >> diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h >> index 941c932265..412fa44d01 100644 >> --- a/hw/net/rocker/rocker.h >> +++ b/hw/net/rocker/rocker.h >> @@ -25,14 +25,9 @@ >> #if defined(DEBUG_ROCKER) >> # define DPRINTF(fmt, ...) \ >> do { \ >> - struct timeval tv; \ >> - char timestr[64]; \ >> - time_t now; \ >> - gettimeofday(&tv, NULL); \ >> - now =3D tv.tv_sec; \ >> - strftime(timestr, sizeof(timestr), "%T", localtime(&now)); \ >> - fprintf(stderr, "%s.%06ld ", timestr, tv.tv_usec); \ >> - fprintf(stderr, "ROCKER: " fmt, ## __VA_ARGS__); \ >> + g_autoptr(GDateTime) now =3D g_date_time_new_now_local(); \ >> + g_autofree char *nowstr =3D g_date_time_format(now, "%T.%f");\ >> + fprintf(stderr, "%s ROCKER: " fmt, nowstr, ## __VA_ARGS__);\ >> } while (0) >> #else >> static inline GCC_FMT_ATTR(1, 2) int DPRINTF(const char *fmt, ...) Reviewed-by: Juan Quintela