qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: John Snow <jsnow@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option
Date: Tue, 17 Sep 2019 20:30:14 +0100	[thread overview]
Message-ID: <87a7b2201l.fsf@linaro.org> (raw)
In-Reply-To: <8ab20bc7-5aa0-53c0-6508-46819566dc07@redhat.com>


John Snow <jsnow@redhat.com> writes:

> On 9/17/19 2:58 PM, Alex Bennée wrote:
>>
>> John Snow <jsnow@redhat.com> writes:
>>
>>> It's not used; so remove the distraction.
>>
>> It's a developer feature so you can run specific builds against the VM
>> images. I certainly have used it, unless you are saying it's broken now?
>>
>
> What consumes it? I can't find where it *does* something:

It's past as the rest:

                -- \ <- all args after this
		$(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
		$(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \

Become argv in:

        args, argv = parse_args(vmcls)
        ...
                    cmd = [vm.BUILD_SCRIPT.format(
                   configure_opts = " ".join(argv),
                   jobs=int(args.jobs),
                   target=args.build_target,
                   verbose = "V=1" if args.verbose else "")]


>
> jhuston@probe ~/s/q/t/vm (docker-partial-fixup)> git grep TARGET_LIST
> Makefile.include:       @echo "    TARGET_LIST=a,b,c             -
> Override target list in builds"
> Makefile.include:               $(if
> $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
> jhuston@probe ~/s/q/t/vm (docker-partial-fixup)> git grep target-list
> Makefile.include:               $(if
> $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
> jhuston@probe ~/s/q/t/vm (docker-partial-fixup)> git grep target_list
> jhuston@probe ~/s/q/t/vm (docker-partial-fixup) [1]>
>
>
> the VM script doesn't seem to pick it up or apply defaults, so I don't
> know where this was supposed to be routed to.
>
>
>>>
>>> Signed-off-by: John Snow <jsnow@redhat.com>
>>> ---
>>>  tests/vm/Makefile.include | 2 --
>>>  1 file changed, 2 deletions(-)
>>>
>>> diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
>>> index fea348e845..61758101fa 100644
>>> --- a/tests/vm/Makefile.include
>>> +++ b/tests/vm/Makefile.include
>>> @@ -28,7 +28,6 @@ vm-help vm-test:
>>>  	@echo
>>>  	@echo "Special variables:"
>>>  	@echo "    BUILD_TARGET=foo		 - Override the build target"
>>> -	@echo "    TARGET_LIST=a,b,c    	 - Override target list in builds"
>>>  	@echo '    EXTRA_CONFIGURE_OPTS="..."'
>>>  	@echo "    J=[0..9]*            	 - Override the -jN parameter for make commands"
>>>  	@echo "    DEBUG=1              	 - Enable verbose output on host and interactive debugging"
>>> @@ -65,7 +64,6 @@ vm-build-%: $(IMAGES_DIR)/%.img
>>>  		$(if $(BUILD_TARGET),--build-target $(BUILD_TARGET)) \
>>>  		--snapshot \
>>>  		--build-qemu $(SRC_PATH) -- \
>>> -		$(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
>>>  		$(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \
>>>  		"  VM-BUILD $*")
>>
>>


--
Alex Bennée


  reply	other threads:[~2019-09-17 19:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 18:49 [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option John Snow
2019-09-17 18:58 ` Alex Bennée
2019-09-17 19:00   ` John Snow
2019-09-17 19:30     ` Alex Bennée [this message]
2019-09-17 19:52       ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7b2201l.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=fam@euphon.net \
    --cc=jsnow@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).