From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Fam Zheng" <famz@redhat.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH] docker: Add fedora-xtensa-cross image
Date: Fri, 22 Jun 2018 16:06:25 +0100 [thread overview]
Message-ID: <87a7rmvp1q.fsf@linaro.org> (raw)
In-Reply-To: <f693508b-37d0-8eb1-4e08-a69b36088eea@amsat.org>
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> On 06/22/2018 11:23 AM, Daniel P. Berrangé wrote:
>> On Fri, Jun 22, 2018 at 11:02:23AM -0300, Philippe Mathieu-Daudé wrote:
>>> As of this commit:
>>>
>>> $ xtensa-linux-gnu-as -v
>>> GNU assembler version 2.29.1 (xtensa-linux-gnu) using BFD version version 2.29.1-1.fc27
>>>
>>> $ xtensa-linux-gnu-gcc -v
>>> Target: xtensa-linux-gnu
>>> gcc version 7.2.1 20170915 (Red Hat Cross 7.2.1-1) (GCC)
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> tests/docker/dockerfiles/fedora-xtensa-cross.docker | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>> create mode 100644 tests/docker/dockerfiles/fedora-xtensa-cross.docker
>>>
>>> diff --git a/tests/docker/dockerfiles/fedora-xtensa-cross.docker b/tests/docker/dockerfiles/fedora-xtensa-cross.docker
>>> new file mode 100644
>>> index 0000000000..6f9521520c
>>> --- /dev/null
>>> +++ b/tests/docker/dockerfiles/fedora-xtensa-cross.docker
>>> @@ -0,0 +1,7 @@
>>> +FROM fedora:latest
>>
>> IIRC, we decided using ':latest' is not a good idea because its meaning
>> will change over time and lead to inconsistent results for devs. We saw
>> this before when patchew reported failure on fedora while developers saw
>> nothing, due to patchew having cached a ":latest" image which was different.
>
> I totally agree with you :)
>
> "FROM fedora:28" works.
Queued with the fedora:28 fix
>
>>
>>> +ENV PACKAGES \
>>> + binutils-xtensa-linux-gnu \
>>> + gcc-xtensa-linux-gnu
>>> +
>>> +RUN dnf install -y $PACKAGES
>>> +RUN rpm -q $PACKAGES | sort > /packages.txt
>>
>>
>> Regards,
>> Daniel
>>
--
Alex Bennée
next prev parent reply other threads:[~2018-06-22 15:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 14:02 [Qemu-devel] [RFC PATCH] docker: Add fedora-xtensa-cross image Philippe Mathieu-Daudé
2018-06-22 14:23 ` Daniel P. Berrangé
2018-06-22 14:33 ` Philippe Mathieu-Daudé
2018-06-22 15:06 ` Alex Bennée [this message]
2018-06-22 15:54 ` Max Filippov
2018-06-22 16:27 ` Alex Bennée
2018-06-22 18:45 ` Max Filippov
2018-06-22 20:33 ` Philippe Mathieu-Daudé
2018-06-22 21:55 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7rmvp1q.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).