From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, eswierk@skyportsystems.com,
jasowang@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/3] e1000 migration changes for 2.12
Date: Tue, 27 Mar 2018 16:06:17 +0200 [thread overview]
Message-ID: <87a7utlijq.fsf@secure.mitica> (raw)
In-Reply-To: <20180327113452.19613-1-dgilbert@redhat.com> (David Alan Gilbert's message of "Tue, 27 Mar 2018 12:34:49 +0100")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Hi Ed, Jason,
> This set of patches change the e1000 migration code to make
> it easier to keep with compatibility with older versions in backwards
> migration; but I do need some advice whether I need to do more as well.
>
> I think the first and second patch are fairly uncontrovercial and I
> would like them for 2.12, since it'll make any future changes easier.
> The third one changes the default behaviour, so again I'd prefer it but
> lets see what you think.
>
> My question however, without knowing the internals of the e1000, is
> whether when ommitting the subsection, should the code in 2.12 be
> changing the data it sends back in the main section of data?
>
> Dave
Reviewed-by: Juan Quintela <quintela@redhat.com>
For the whole series.
I would have merged patch 1 & 2, but as you are the one coding them.
Later, Juan.
prev parent reply other threads:[~2018-03-27 14:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 11:34 [Qemu-devel] [PATCH 0/3] e1000 migration changes for 2.12 Dr. David Alan Gilbert (git)
2018-03-27 11:34 ` [Qemu-devel] [PATCH 1/3] e1000: Convert v3 fields to subsection Dr. David Alan Gilbert (git)
2018-03-27 11:34 ` [Qemu-devel] [PATCH 2/3] e1000: wire new subsection to property Dr. David Alan Gilbert (git)
2018-03-27 11:34 ` [Qemu-devel] [PATCH 3/3] e1000: Old machine types, turn new subsection off Dr. David Alan Gilbert (git)
2018-03-27 16:07 ` Paolo Bonzini
2018-03-27 16:47 ` Dr. David Alan Gilbert
2018-03-27 17:28 ` Paolo Bonzini
2018-03-27 18:01 ` Dr. David Alan Gilbert
2018-03-27 20:17 ` Paolo Bonzini
2018-03-28 0:31 ` Ed Swierk
2018-03-27 13:06 ` [Qemu-devel] [PATCH 0/3] e1000 migration changes for 2.12 Jason Wang
2018-03-27 14:26 ` Dr. David Alan Gilbert
2018-03-27 23:53 ` Ed Swierk
2018-03-28 2:45 ` Jason Wang
2018-03-27 14:06 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7utlijq.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eswierk@skyportsystems.com \
--cc=jasowang@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).