Re: [Qemu-devel] [PATCH v12 04/27] target: [tcg] Add generic translation framework

["Alex Bennée" <alex.bennee@linaro.org>]

Lluís Vilanova <vilanova@ac.upc.edu> writes:

> Alex Bennée writes:
>
>> Lluís Vilanova <vilanova@ac.upc.edu> writes:
>
>>> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
<snip>
>>> +
>>> +        translate_block_tcg_check(db);
>>> +    }
>
>> This may be a personal taste thing but having while(true) {} and breaks
>> is harder to follow than do { stuff } while (!done);
>
> I think it is. I prefer to see the loop condition up-front, unless a do-while
> makes the condition logic substantially simpler.

Yes but in this case the condition is "go forever" unless we break (or
goto) out. I'd be happy with the while at the top if it was an actual
condition.

--
Alex Bennée