From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCVXi-00076r-HB for qemu-devel@nongnu.org; Tue, 07 Jul 2015 12:16:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCVXe-0004w9-4q for qemu-devel@nongnu.org; Tue, 07 Jul 2015 12:16:22 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:33236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCVXd-0004vk-OE for qemu-devel@nongnu.org; Tue, 07 Jul 2015 12:16:18 -0400 Received: by wiwl6 with SMTP id l6so319682164wiw.0 for ; Tue, 07 Jul 2015 09:16:17 -0700 (PDT) References: <1435330053-18733-1-git-send-email-fred.konrad@greensocs.com> <1435330053-18733-18-git-send-email-fred.konrad@greensocs.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1435330053-18733-18-git-send-email-fred.konrad@greensocs.com> Date: Tue, 07 Jul 2015 17:16:14 +0100 Message-ID: <87a8v89c4x.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH V6 17/18] translate-all: introduces tb_flush_safe. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com Cc: mttcg@listserver.greensocs.com, peter.maydell@linaro.org, a.spyridakis@virtualopensystems.com, mark.burton@greensocs.com, agraf@suse.de, qemu-devel@nongnu.org, guillaume.delbergue@greensocs.com, pbonzini@redhat.com, alistair.francis@xilinx.com fred.konrad@greensocs.com writes: > From: KONRAD Frederic > > tb_flush is not thread safe we definitely need to exit VCPUs to do that. > This introduces tb_flush_safe which just creates an async safe work which will > do a tb_flush later. > > Signed-off-by: KONRAD Frederic > --- > include/exec/exec-all.h | 1 + > translate-all.c | 15 +++++++++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h > index 484c351..b5e4fb3 100644 > --- a/include/exec/exec-all.h > +++ b/include/exec/exec-all.h > @@ -219,6 +219,7 @@ static inline unsigned int tb_phys_hash_func(tb_page_addr_t pc) > > void tb_free(TranslationBlock *tb); > void tb_flush(CPUArchState *env); > +void tb_flush_safe(CPUArchState *env); > void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr); > > #if defined(USE_DIRECT_JUMP) > diff --git a/translate-all.c b/translate-all.c > index 468648d..8bd8fe8 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -815,6 +815,21 @@ static void page_flush_tb(void) > } > } > > +static void tb_flush_work(void *opaque) > +{ > + CPUArchState *env = opaque; > + tb_flush(env); > +} > + > +void tb_flush_safe(CPUArchState *env) > +{ > +#if 0 /* !MTTCG */ > + tb_flush(env); > +#else > + async_run_safe_work_on_cpu(ENV_GET_CPU(env), tb_flush_work, env); > +#endif /* MTTCG */ > +} Same comments about build system fixups. > + > /* flush all the translation blocks */ > /* XXX: tb_flush is currently not thread safe */ > void tb_flush(CPUArchState *env1) -- Alex Bennée