From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55760)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1YUdyC-0003ff-Ss
	for qemu-devel@nongnu.org; Sun, 08 Mar 2015 12:22:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1YUdy7-00073f-Sz
	for qemu-devel@nongnu.org; Sun, 08 Mar 2015 12:22:24 -0400
Received: from e28smtp01.in.ibm.com ([122.248.162.1]:53469)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1YUdy7-00073K-7d
	for qemu-devel@nongnu.org; Sun, 08 Mar 2015 12:22:19 -0400
Received: from /spool/local
	by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aneesh.kumar@linux.vnet.ibm.com>;
	Sun, 8 Mar 2015 21:52:12 +0530
Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61])
	by d28dlp03.in.ibm.com (Postfix) with ESMTP id 915371258061
	for <qemu-devel@nongnu.org>; Sun,  8 Mar 2015 21:53:36 +0530 (IST)
Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66])
	by d28relay04.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
	t28GM1vJ33030332
	for <qemu-devel@nongnu.org>; Sun, 8 Mar 2015 21:52:02 +0530
Received: from d28av04.in.ibm.com (localhost [127.0.0.1])
	by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	t28GM1rb017234
	for <qemu-devel@nongnu.org>; Sun, 8 Mar 2015 21:52:01 +0530
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <b98f675750ef0535cab41225240db1657fc2fe00.1425678142.git.mjt@msgid.tls.msk.ru>
References: <cover.1425678142.git.mjt@msgid.tls.msk.ru>
	<b98f675750ef0535cab41225240db1657fc2fe00.1425678142.git.mjt@msgid.tls.msk.ru>
Date: Sun, 08 Mar 2015 21:51:58 +0530
Message-ID: <87a8zn4fyx.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org

Michael Tokarev <mjt@tls.msk.ru> writes:

> All filesystem methods that call common v9fs_request() function
> also convert return value to errno.  Move this conversion to the
> common function and remove redundand error handling in methods.
>
> I didn't remove local `retval' variable in simple functions to
> keep the code consistent.
>
> Also, proxy_truncate() seem to prefer zero successful return
> instead of returning whatever the helper returned, maybe this
> should be changed.
>
> This also removes (harmless) double call to v9fs_string_free()
> in proxy_mkdir(), and renames local variables in some functions
> for consistency.

Can you keep the variable rename as a separate patch. That will make it
easier to review. Let me know if you want me to do that for you.

-aneesh