From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoSSp-00072F-W0 for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:35:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoSSh-0003Rh-42 for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:35:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoSSg-0003Rd-OZ for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:35:30 -0500 From: Markus Armbruster References: <1415776088-4708-1-git-send-email-syeon.hwang@samsung.com> Date: Wed, 12 Nov 2014 08:35:25 +0100 In-Reply-To: <1415776088-4708-1-git-send-email-syeon.hwang@samsung.com> (SeokYeon Hwang's message of "Wed, 12 Nov 2014 16:08:08 +0900") Message-ID: <87a93wc1mq.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v4] error: passing a negative value to an os_errno is wrong List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: SeokYeon Hwang Cc: kongjianjun@gmail.com, paolo.bonzini@gmail.com, qemu-devel@nongnu.org, mreitz@redhat.com SeokYeon Hwang writes: > Added 'assert(os_errno >= 0)' in 'error_set_errno()'. > > Signed-off-by: SeokYeon Hwang > --- > util/error.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/util/error.c b/util/error.c > index 2ace0d8..6c9d995 100644 > --- a/util/error.c > +++ b/util/error.c > @@ -62,6 +62,7 @@ void error_set_errno(Error **errp, int os_errno, ErrorClass err_class, > return; > } > assert(*errp == NULL); > + assert(os_errno >= 0); > > err = g_malloc0(sizeof(*err)); Too risky for 2.2 at this stage, but fine for 2.3. Reviewed-by: Markus Armbruster