From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSO7t-0002IQ-EW for qemu-devel@nongnu.org; Fri, 12 Sep 2014 06:30:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSO7e-0005Vx-Q5 for qemu-devel@nongnu.org; Fri, 12 Sep 2014 06:30:49 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:46708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSO7d-0005UF-Np for qemu-devel@nongnu.org; Fri, 12 Sep 2014 06:30:34 -0400 Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 12 Sep 2014 20:30:29 +1000 From: Nikunj A Dadhania In-Reply-To: <1410497830.2982.394.camel@ul30vt.home> References: <1410496975-13257-1-git-send-email-nikunj@linux.vnet.ibm.com> <1410497830.2982.394.camel@ul30vt.home> Date: Fri, 12 Sep 2014 16:00:12 +0530 Message-ID: <87a965w2q3.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] Skip vfio mmap bar regions during memory dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: aik@ozlabs.ru, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de Alex Williamson writes: > On Fri, 2014-09-12 at 10:12 +0530, Nikunj A Dadhania wrote: >> The PCI MMIO might be disabled or the device in the reset state. >> Make sure we do not dump these memory regions. >> >> Signed-off-by: Nikunj A Dadhania >> --- > > If you don't want to dump a memory region then add the ability to set a > no-dump flag on the region and have vfio call it, don't make something > as specific as a vfio mmap region. Thanks, Sure, do you want me to separate it to two patches: 1) Adding skip_dump flag and accessors 2) VFIO using the accessors? Regards, Nikunj