From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35892)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1Vv7eJ-0008BR-By
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 10:42:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1Vv7e5-0001GY-Md
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 10:42:31 -0500
Received: from e23smtp09.au.ibm.com ([202.81.31.142]:57690)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1Vv7e4-0001BM-TL
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 10:42:17 -0500
Received: from /spool/local
	by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aneesh.kumar@linux.vnet.ibm.com>;
	Tue, 24 Dec 2013 01:42:14 +1000
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <E5B749D6-D155-4F65-B312-E2A32A80A8C6@suse.de>
References: <1387469084-17116-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
	<17DB5D62-E80A-4774-A8F9-DBB47AC3523C@suse.de>
	<E5B749D6-D155-4F65-B312-E2A32A80A8C6@suse.de>
Date: Mon, 23 Dec 2013 21:12:04 +0530
Message-ID: <87a9frzi9f.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH V4] kvm: Add a new machine
	property kvm-type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-ppc <qemu-ppc@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Paul Mackerras <paulus@samba.org>, QEMU Developers <qemu-devel@nongnu.org>

Alexander Graf <agraf@suse.de> writes:

> On Dec 20, 2013, at 11:55 AM, Alexander Graf <agraf@suse.de> wrote:
>
>> 
>> On 19.12.2013, at 17:04, Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> wrote:
>> 
>>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>>> 
>>> Targets like ppc64 support different typed of KVM, one which use
>>> hypervisor mode and the other which doesn't. Add a new machine
>>> property kvm-type that helps in selecting the respective ones
>>> We also add a new QEMUMachine callback get_vm_type that helps
>>> in mapping the string representation of kvm type specified.
>>> 
>>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>> 
>> Thanks, applied to ppc-next.
>
> This breaks compilation for ppc{,64}-linux-user. Please fix that up
> and submit a v5. I've taken this patch from my tree for now :).

Sent v5 with the below fix folded

diff --git a/kvm-stub.c b/kvm-stub.c
index c27b69076572..6dd4454a640c 100644
--- a/kvm-stub.c
+++ b/kvm-stub.c
@@ -19,8 +19,6 @@
 #include "hw/pci/msi.h"
 #endif
 
-#include "hw/boards.h"
-
 KVMState *kvm_state;
 bool kvm_kernel_irqchip;
 bool kvm_async_interrupts_allowed;
@@ -30,6 +28,7 @@ bool kvm_gsi_routing_allowed;
 bool kvm_gsi_direct_mapping;
 bool kvm_allowed;
 bool kvm_readonly_mem_allowed;
+typedef struct QEMUMachine QEMUMachine;
 
 int kvm_init_vcpu(CPUState *cpu)
 {