[Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

[Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

[Stefano Stabellini]

Anthony,
please pull the following changes since commit
6a4e17711442849bf2cc731ccddef5a2a2d92d29:                                                          
                                                                                                                                      
  ssh://xenbits.xen.org/home/sstabellini/git/qemu-dm.git xen_fixes_20130603                                                           
                                                                                                                                      

The first 4 commits are important fixes that should be backported to the
stable trees. The following should be backported at least up to QEMU
v1.3 included:

49fa988 xen: simplify xen_enabled
a7d4207 main_loop: do not set nonblocking if xen_enabled()
9f24a80 xen: start PCI hole at 0xe0000000 (same as pc_init1 and qemu-xen-traditional)

The following should be backported only to QEMU v1.5:

58ee9b0 xen_machine_pv: do not create a dummy CPU in machine->init

The last 2 are just cleanups.



Stefano Stabellini (6):
      xen: simplify xen_enabled
      main_loop: do not set nonblocking if xen_enabled()
      xen_machine_pv: do not create a dummy CPU in machine->init
      xen: start PCI hole at 0xe0000000 (same as pc_init1 and qemu-xen-traditional)
      xen: remove xen_vcpu_init
      xen: use pc_init_pci instead of pc_init_pci_no_kvmclock

 hw/i386/pc_piix.c        |   11 +++++------
 hw/i386/xen_machine_pv.c |   16 ----------------
 include/hw/i386/pc.h     |    3 +++
 include/hw/xen/xen.h     |    5 -----
 vl.c                     |    2 +-
 xen-all.c                |   35 ++++++-----------------------------
 6 files changed, 15 insertions(+), 57 deletions(-)


Cheers,

Stefano

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

[Anthony Liguori]

Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:

> Anthony,
> please pull the following changes since commit
> 6a4e17711442849bf2cc731ccddef5a2a2d92d29:                                                          
>                                                                                                                                       
>   ssh://xenbits.xen.org/home/sstabellini/git/qemu-dm.git
>   xen_fixes_20130603                                                           


Please use git-request-pull to generate your cover letter.  If you are,
then you probably need a newer version.

That's also not the normal URI that you request pulls from...

Regards,

Anthony Liguori

>                                                                                                                                       
>
> The first 4 commits are important fixes that should be backported to the
> stable trees. The following should be backported at least up to QEMU
> v1.3 included:
>
> 49fa988 xen: simplify xen_enabled
> a7d4207 main_loop: do not set nonblocking if xen_enabled()
> 9f24a80 xen: start PCI hole at 0xe0000000 (same as pc_init1 and qemu-xen-traditional)
>
> The following should be backported only to QEMU v1.5:
>
> 58ee9b0 xen_machine_pv: do not create a dummy CPU in machine->init
>
> The last 2 are just cleanups.
>
>
>
> Stefano Stabellini (6):
>       xen: simplify xen_enabled
>       main_loop: do not set nonblocking if xen_enabled()
>       xen_machine_pv: do not create a dummy CPU in machine->init
>       xen: start PCI hole at 0xe0000000 (same as pc_init1 and qemu-xen-traditional)
>       xen: remove xen_vcpu_init
>       xen: use pc_init_pci instead of pc_init_pci_no_kvmclock
>
>  hw/i386/pc_piix.c        |   11 +++++------
>  hw/i386/xen_machine_pv.c |   16 ----------------
>  include/hw/i386/pc.h     |    3 +++
>  include/hw/xen/xen.h     |    5 -----
>  vl.c                     |    2 +-
>  xen-all.c                |   35 ++++++-----------------------------
>  6 files changed, 15 insertions(+), 57 deletions(-)
>
>
> Cheers,
>
> Stefano

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

[Stefano Stabellini]

On Mon, 3 Jun 2013, Anthony Liguori wrote:
> Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:
> 
> > Anthony,
> > please pull the following changes since commit
> > 6a4e17711442849bf2cc731ccddef5a2a2d92d29:                                                          
> >                                                                                                                                       
> >   ssh://xenbits.xen.org/home/sstabellini/git/qemu-dm.git
> >   xen_fixes_20130603                                                           
> 
> 
> Please use git-request-pull to generate your cover letter.  If you are,
> then you probably need a newer version.
> 
> That's also not the normal URI that you request pulls from...

Argh sorry! Actually that's the first time I used git-request-pull :/

The tree is the same as usual:

git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen_fixes_20130603

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

[Anthony Liguori]

Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:

> On Mon, 3 Jun 2013, Anthony Liguori wrote:
>> Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:
>> 
>> > Anthony,
>> > please pull the following changes since commit
>> > 6a4e17711442849bf2cc731ccddef5a2a2d92d29:                                                          
>> >                                                                                                                                       
>> >   ssh://xenbits.xen.org/home/sstabellini/git/qemu-dm.git
>> >   xen_fixes_20130603                                                           
>> 
>> 
>> Please use git-request-pull to generate your cover letter.  If you are,
>> then you probably need a newer version.
>> 
>> That's also not the normal URI that you request pulls from...
>
> Argh sorry! Actually that's the first time I used git-request-pull :/

What git version?

> The tree is the same as usual:
>
> git://xenbits.xen.org/people/sstabellini/qemu-dm.git
> xen_fixes_20130603

Regards,

Anthony Liguori

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

[Stefano Stabellini]

On Mon, 3 Jun 2013, Anthony Liguori wrote:
> Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:
> 
> > On Mon, 3 Jun 2013, Anthony Liguori wrote:
> >> Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:
> >> 
> >> > Anthony,
> >> > please pull the following changes since commit
> >> > 6a4e17711442849bf2cc731ccddef5a2a2d92d29:                                                          
> >> >                                                                                                                                       
> >> >   ssh://xenbits.xen.org/home/sstabellini/git/qemu-dm.git
> >> >   xen_fixes_20130603                                                           
> >> 
> >> 
> >> Please use git-request-pull to generate your cover letter.  If you are,
> >> then you probably need a newer version.
> >> 
> >> That's also not the normal URI that you request pulls from...
> >
> > Argh sorry! Actually that's the first time I used git-request-pull :/
> 
> What git version?

git version 1.7.2.5

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

[Anthony Liguori]

Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:

> On Mon, 3 Jun 2013, Anthony Liguori wrote:
>> Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:
>> 
>> > On Mon, 3 Jun 2013, Anthony Liguori wrote:
>> >> Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:
>> >> 
>> >> > Anthony,
>> >> > please pull the following changes since commit
>> >> > 6a4e17711442849bf2cc731ccddef5a2a2d92d29:                                                          
>> >> >                                                                                                                                       
>> >> >   ssh://xenbits.xen.org/home/sstabellini/git/qemu-dm.git
>> >> >   xen_fixes_20130603                                                           
>> >> 
>> >> 
>> >> Please use git-request-pull to generate your cover letter.  If you are,
>> >> then you probably need a newer version.
>> >> 
>> >> That's also not the normal URI that you request pulls from...
>> >
>> > Argh sorry! Actually that's the first time I used git-request-pull :/
>> 
>> What git version?
>
> git version 1.7.2.5


Your mailer is line wrapping.  I'd suggest using git-send-email in the
future.

Peter was kind enough to put up this page:

http://wiki.qemu.org/Contribute/SubmitAPullRequest

Regards,

Anthony Liguori

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

[Peter Maydell]

On 3 June 2013 22:13, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Peter was kind enough to put up this page:
>
> http://wiki.qemu.org/Contribute/SubmitAPullRequest

That just has the stuff that I could think of off the
top of my head in half an hour or so, so other people
should feel free to add/edit items.

thanks
-- PMM

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

[Stefano Stabellini]

On Mon, 3 Jun 2013, Anthony Liguori wrote:
> Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:
> 
> > On Mon, 3 Jun 2013, Anthony Liguori wrote:
> >> Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:
> >> 
> >> > On Mon, 3 Jun 2013, Anthony Liguori wrote:
> >> >> Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:
> >> >> 
> >> >> > Anthony,
> >> >> > please pull the following changes since commit
> >> >> > 6a4e17711442849bf2cc731ccddef5a2a2d92d29:                                                          
> >> >> >                                                                                                                                       
> >> >> >   ssh://xenbits.xen.org/home/sstabellini/git/qemu-dm.git
> >> >> >   xen_fixes_20130603                                                           
> >> >> 
> >> >> 
> >> >> Please use git-request-pull to generate your cover letter.  If you are,
> >> >> then you probably need a newer version.
> >> >> 
> >> >> That's also not the normal URI that you request pulls from...
> >> >
> >> > Argh sorry! Actually that's the first time I used git-request-pull :/
> >> 
> >> What git version?
> >
> > git version 1.7.2.5
> 
> 
> Your mailer is line wrapping.  I'd suggest using git-send-email in the
> future.
> 
> Peter was kind enough to put up this page:
> 
> http://wiki.qemu.org/Contribute/SubmitAPullRequest

Thanks for the link. Even though maybe partial, having a document
that explains the process is great (I wish there was one for Linux too).

The page hints at patches resubmitted with the PULL request: do we
encourage people to do that? If so, it's worth writing down. On the LKML
we don't do that usually, so it's not obvious.

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

[Stefano Stabellini]

On Tue, 4 Jun 2013, Stefano Stabellini wrote:
> On Mon, 3 Jun 2013, Anthony Liguori wrote:
> > Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:
> > 
> > > On Mon, 3 Jun 2013, Anthony Liguori wrote:
> > >> Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:
> > >> 
> > >> > On Mon, 3 Jun 2013, Anthony Liguori wrote:
> > >> >> Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:
> > >> >> 
> > >> >> > Anthony,
> > >> >> > please pull the following changes since commit
> > >> >> > 6a4e17711442849bf2cc731ccddef5a2a2d92d29:                                                          
> > >> >> >                                                                                                                                       
> > >> >> >   ssh://xenbits.xen.org/home/sstabellini/git/qemu-dm.git
> > >> >> >   xen_fixes_20130603                                                           
> > >> >> 
> > >> >> 
> > >> >> Please use git-request-pull to generate your cover letter.  If you are,
> > >> >> then you probably need a newer version.
> > >> >> 
> > >> >> That's also not the normal URI that you request pulls from...
> > >> >
> > >> > Argh sorry! Actually that's the first time I used git-request-pull :/
> > >> 
> > >> What git version?
> > >
> > > git version 1.7.2.5
> > 
> > 
> > Your mailer is line wrapping.  I'd suggest using git-send-email in the
> > future.
> > 
> > Peter was kind enough to put up this page:
> > 
> > http://wiki.qemu.org/Contribute/SubmitAPullRequest
> 
> Thanks for the link. Even though maybe partial, having a document
> that explains the process is great (I wish there was one for Linux too).
> 
> The page hints at patches resubmitted with the PULL request: do we
> encourage people to do that? If so, it's worth writing down. On the LKML
> we don't do that usually, so it's not obvious.
>

Also, would you like me to resubmit the pull request?

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

[Peter Maydell]

On 4 June 2013 11:59, Stefano Stabellini
<stefano.stabellini@eu.citrix.com> wrote:
>> http://wiki.qemu.org/Contribute/SubmitAPullRequest
>
> Thanks for the link. Even though maybe partial, having a document
> that explains the process is great (I wish there was one for Linux too).
>
> The page hints at patches resubmitted with the PULL request: do we
> encourage people to do that? If so, it's worth writing down. On the LKML
> we don't do that usually, so it's not obvious.

If you mean "resend all the patches as emails with the pull
request", that was what I was trying to say in the first
item. If you think it's not clearly worded enough do edit
the wiki page...

-- PMM

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

[Stefano Stabellini]

On Tue, 4 Jun 2013, Peter Maydell wrote:
> On 4 June 2013 11:59, Stefano Stabellini
> <stefano.stabellini@eu.citrix.com> wrote:
> >> http://wiki.qemu.org/Contribute/SubmitAPullRequest
> >
> > Thanks for the link. Even though maybe partial, having a document
> > that explains the process is great (I wish there was one for Linux too).
> >
> > The page hints at patches resubmitted with the PULL request: do we
> > encourage people to do that? If so, it's worth writing down. On the LKML
> > we don't do that usually, so it's not obvious.
> 
> If you mean "resend all the patches as emails with the pull
> request", that was what I was trying to say in the first
> item. If you think it's not clearly worded enough do edit
> the wiki page...

OK, maybe it was already clear enough, nonetheless I made my tiny
contribution to make it even clearer :-)

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

[Anthony Liguori]

Stefano Stabellini <stefano.stabellini@eu.citrix.com> writes:

> On Tue, 4 Jun 2013, Stefano Stabellini wrote:
>> On Mon, 3 Jun 2013, Anthony Liguori wrote:
>> 
>> Thanks for the link. Even though maybe partial, having a document
>> that explains the process is great (I wish there was one for Linux too).
>> 
>> The page hints at patches resubmitted with the PULL request: do we
>> encourage people to do that? If so, it's worth writing down. On the LKML
>> we don't do that usually, so it's not obvious.
>>
>
> Also, would you like me to resubmit the pull request?

No need, I'll process it manually.

Regards,

Anthony Liguori