From: Juan Quintela <quintela@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, pl@kamp.de,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, owasserm@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] migration: initialize RAM to zero
Date: Tue, 09 Apr 2013 17:22:31 +0200 [thread overview]
Message-ID: <87a9p7bufc.fsf@elfo.elfo> (raw)
In-Reply-To: <51642C0C.6010607@redhat.com> (Paolo Bonzini's message of "Tue, 09 Apr 2013 16:56:12 +0200")
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 09/04/2013 15:20, Markus Armbruster ha scritto:
>>> > -#if defined(CONFIG_VALGRIND)
>>> > - if (running_on_valgrind < 0) {
>>> > - /* First call, test whether we are running on Valgrind.
>>> > - This is a substitute for RUNNING_ON_VALGRIND from valgrind.h. */
>>> > - const char *ld = getenv("LD_PRELOAD");
>>> > - running_on_valgrind = (ld != NULL && strstr(ld, "vgpreload"));
>>> > + if ((intptr_t) ptr == -1) {
>> Recommend ptr == MAP_FAILED
>>
>
> Worth respinning?
Do it, and put the:
Reviewed-by: Juan Quintela <quintela@redhat.com>
prev parent reply other threads:[~2013-04-09 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 12:52 [Qemu-devel] [PATCH v2] migration: initialize RAM to zero Paolo Bonzini
2013-04-09 13:20 ` Markus Armbruster
2013-04-09 14:56 ` Paolo Bonzini
2013-04-09 15:04 ` Markus Armbruster
2013-04-09 15:22 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9p7bufc.fsf@elfo.elfo \
--to=quintela@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).